v2.2: accounts-db: Use NoHashHasher in AccountStorageMap (backport of #4822)
#4920
+23
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DashMap` uses SipHash by default. `AccountStorageMap` uses `Slot` as a key and therefore it doesn't have any chance of collisions. We can skip hashing the key entirely. (cherry picked from commit cd04323)
|
Justification to backport: We're very early in the v2.2 branch, and this is a simple change to improve the performance of the hashing for the map that does Slot -> AccountStorageEntry lookups. |
brooksprumo
approved these changes
Feb 11, 2025
t-nelson
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DashMapuses SipHash by default.AccountStorageMapusesSlotas a key and therefore it doesn't have any chance of collisions.Summary of Changes
We can skip hashing the key entirely.
Ref #4276
This is an automatic backport of pull request #4822 done by [Mergify](https://mergify.com).