ledger-tool: Allow dead slots for slot command when metadata absent #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slot command will reject dead slots by default. This behavior can be overridden by passing --allow-dead-slots. Additionally, in the event that transaction metadata is missing or the slot is incomplete in the blockstore, a best effort attempt will be made to get as much data out as possible. This fallback case did not have the allow dead slots parameter plumbed through, so hook it up to allow fetching dead, partial slots
e65c39f to
1307709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The slot command will reject dead slots by default. This behavior can be overridden by passing --allow-dead-slots. Additionally, in the event that transaction metadata is missing or the slot is incomplete in the blockstore, a best effort attempt will be made to get as much data out as possible.
Summary of Changes
This fallback case did not have the allow dead slots parameter plumbed through, so hook it up to allow fetching dead, partial slots