agave-validator: add args tests for staked-nodes-overrides

validator/src/commands/staked_nodes_overrides/mod.rs

@@ -1,11 +1,26 @@
 use {
-    crate::{admin_rpc_service, cli::DefaultArgs},
+    crate::{admin_rpc_service, cli::DefaultArgs, commands::FromClapArgMatches},
     clap::{App, Arg, ArgMatches, SubCommand},
     std::{path::Path, process::exit},
 };
 
+const COMMAND: &str = "staked-nodes-overrides";
+
+#[derive(Debug, PartialEq)]
+pub struct StakedNodesOverridesArg {
+    pub path: String,
+}
+
+impl FromClapArgMatches for StakedNodesOverridesArg {
+    fn from_clap_arg_match(matches: &ArgMatches) -> Self {
+        StakedNodesOverridesArg {
+            path: matches.value_of("path").unwrap().to_string(),
+        }
+    }
+}
+
 pub fn command(_default_args: &DefaultArgs) -> App<'_, '_> {
-    SubCommand::with_name("staked-nodes-overrides")
+    SubCommand::with_name(COMMAND)
         .about("Overrides stakes of specific node identities.")
         .arg(
             Arg::with_name("path")
@@ -22,23 +37,51 @@ pub fn command(_default_args: &DefaultArgs) -> App<'_, '_> {
 }
 
 pub fn execute(matches: &ArgMatches, ledger_path: &Path) {
-    if !matches.is_present("path") {
+    let staked_nodes_overrides_arg = StakedNodesOverridesArg::from_clap_arg_match(matches);
+    if staked_nodes_overrides_arg.path.is_empty() {
         println!("staked-nodes-overrides requires argument of location of the configuration");
         exit(1);
     }
 
-    let path = matches.value_of("path").unwrap();
-
     let admin_client = admin_rpc_service::connect(ledger_path);
     admin_rpc_service::runtime()
         .block_on(async move {
             admin_client
                 .await?
-                .set_staked_nodes_overrides(path.to_string())
+                .set_staked_nodes_overrides(staked_nodes_overrides_arg.path)
                 .await
         })
         .unwrap_or_else(|err| {
             println!("setStakedNodesOverrides request failed: {err}");
             exit(1);
         });
 }
+
+#[cfg(test)]
+mod tests {
+    use {
+        super::*,
+        crate::commands::tests::{
+            verify_args_struct_by_command, verify_args_struct_by_command_is_error,
+        },
+    };
+
+    #[test]
+    fn verify_args_struct_by_command_staked_nodes_overrides_default() {
+        verify_args_struct_by_command_is_error::<StakedNodesOverridesArg>(
+            command(&DefaultArgs::default()),
+            vec![COMMAND],
+        );
+    }
+
+    #[test]
+    fn verify_args_struct_by_command_staked_nodes_overrides_path() {
+        verify_args_struct_by_command(
+            command(&DefaultArgs::default()),
+            vec![COMMAND, "test.json"],
+            StakedNodesOverridesArg {
+                path: "test.json".to_string(),
+            },
+        );
+    }
+}