-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace solana_sdk::pubkey with solana_pubkey in ledger #4235
replace solana_sdk::pubkey with solana_pubkey in ledger #4235
Conversation
@@ -2,7 +2,7 @@ use { | |||
itertools::Itertools, | |||
rand::distributions::{Distribution, WeightedIndex}, | |||
rand_chacha::{rand_core::SeedableRng, ChaChaRng}, | |||
solana_sdk::pubkey::Pubkey, | |||
solana_pubkey::Pubkey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make this substitution on a bunch more files in solana_ledger
. Looks like:
benches/blockstore.rs
src/blockstore.rs
- This file looks to have a redundant import in the test module as well
src/blockstore_db.rs
src/blockstore_processor.rs
- Redundant import in test module as well
src/genesis_utils.rs
src/leader_schedule.rs
- Already done per the highlighted line in the diff
src/leader_schedule_cache.rs
src/leader_schedule_utils.rs
src/shred.rs
src/shredder.rs
src/sigverify_shreds.rs
src/staking_utils.rs
src/token_balances.rs
src/transaction_address_lookup_table_scanner.rs
src/shred/merkle.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do this in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm somewhat inclined to include it in this same PR. The PR title states "replace solana_sdk::pubkey with solana_pubkey in ledger", and without these changes, that is not fully accomplished. The diff should still be pretty small with these changes. Finally, if we were to do those changes in a separate PR, then I'd argue we should revert this line in src/leader_schedule.rs
for the sake of consistency across the crate.
That being said, I don't want to punish a good deed. So, if you're opposed to tagging the change onto this PR, I'd probably still be fine pushing the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah by that PR title I meant sed -i 's/solana_sdk::pubkey/solana_pubkey/g'
89dc08a
to
94e9da1
Compare
Problem
This crate uses solana_sdk in many places. It will take multiple PRs to replace it everywhere
Summary of Changes
Find and replace
solana_sdk::pubkey
withsolana_pubkey