Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace solana_sdk::pubkey with solana_pubkey in gossip #4234

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

kevinheavey
Copy link

Problem

This crate uses solana_sdk in many places. It will take multiple PRs to replace it everywhere

Summary of Changes

Find and replace solana_sdk::pubkey with solana_pubkey

@kevinheavey kevinheavey requested a review from wen-coding January 2, 2025 19:01
@gregcusack gregcusack self-requested a review January 3, 2025 20:01
@gregcusack
Copy link

is the end goal to get rid of solana_sdk from gossip all together? with the overall goal of reducing compile time/binary size?

@kevinheavey
Copy link
Author

is the end goal to get rid of solana_sdk from gossip all together? with the overall goal of reducing compile time/binary size?

Yes

Copy link

@gregcusack gregcusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Jan 6, 2025
@mergify mergify bot merged commit f27dda7 into anza-xyz:master Jan 6, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants