Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump rocksdb from 0.22.0 to 0.23.0 #4210

Merged
merged 4 commits into from
Feb 11, 2025
Merged

build(deps): bump rocksdb from 0.22.0 to 0.23.0 #4210

merged 4 commits into from
Feb 11, 2025
+35 −44

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Dec 25, 2024 •
edited
Loading

Bumps rocksdb from 0.22.0 to 0.23.0.

Release notes

Sourced from rocksdb's releases.

v0.23.0

What's Changed

... (truncated)

Changelog

Sourced from rocksdb's changelog.

0.23.0 (2024-12-23)

  • Build status badge and other bits in README.md (jdanford)
  • Adds crt_static method (spector-9)
  • Fix ptr::copy requires both ptrs to be non-null (ruanpetterson)
  • Add portable feature for RocksDB build (sujayakar)
  • Update README.md with a new section for the portable feature (sujayakar)
  • Update to RocksDB 9.0.0 (Dirreke)
  • Add readme for mt_static feature (spector-9)
  • Make BackupEngine Send (widagdos)
  • Add linking libatomic command to build.rs to allow building (willemolding)
  • Revert portable feature as it doesn't do anything (zaidoon1)
  • Add delete_range to OptimisticTransactionDB (vadim-su)
  • Update rust toolchain to 1.70.0 (widagdos)
  • Bump snappy to 1.2.0 (aleksuss)
  • Document that default column family doesn't inherit open options of db (0xdeafbeef)
  • Toolchain: pin toolchain to rust 1.70.0 (cratelyn)
  • Add clippy MSRV and some clippy fixes (Congyuwang)
  • Port all value of ReadTier (w41ter)
  • Update src/db_options.rs (w41ter)
  • Add option set_avoid_unnecessary_blocking_io (w41ter)
  • Add option to enable autotuned ratelimiter (w41ter)
  • Add support for enabling blob cache (exabytes18)
  • Fix: android build in 32-bit devices (LucasXu0)
  • Support user defined timestamp in rust bindings (siyuan0322)
  • Bump lz4 1.10 (agourlay)
  • Properties for the TransactionDB (4TT1L4)
  • Improvements to user defined timestamp (larry0x)
  • Implement Sync for {Bound}ColumnFamily (jhpratt)
  • Use the provided system rocksdb prebuilt on FreeBSD (girlbossceo)
  • Deprecated Node version and outdated GitHub Actions (4TT1L4)
  • Fix cargo audit check in GitHub Actions CI (aleksuss)
  • RUSTSEC-2023-0020: const-cstr is Unmaintained (4TT1L4)
  • TransactionDB support in MemoryUsageBuilder (4TT1L4)
  • Bump tikv-jemalloc-sys to 0.6 (0xdeafbeef)
  • Improve statistics by auto gen enum Ticker & enum Histogram (rockeet)
  • Expose LRU cache options (athre0z)
  • Add Env::from_raw constructor (jgraettinger)
  • Fix unsoundness via impure AsRef (niklasf)
  • Fix two tests that want to write to the current working directory (mr-c)
  • Add missing supported BSD OSes (drizzt)
  • Fix column family creation race (stuhood)
  • Allow using static feature for the bindgen (Congyuwang)
  • Use tempfile instead of the current working directory (mr-c)
  • Update to RocksDB 9.7.4 (niklasf)
  • Add with_capacity_bytes to WriteBatch (0xdeafbeef)
  • ci: make most directories read-only before running the tests (mr-c)
  • Add ROCKSDB_SCHED_GETCPU_PRESENT for Linux build config (popcnt1)
  • Add set_compaction_pri to Options (0xdeafbeef)
  • Implement get_db_identity using rocksdb_get_db_identity (evanj)

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Dec 25, 2024
@dependabot dependabot bot force-pushed the dependabot/cargo/rocksdb-0.23.0 branch 2 times, most recently from ea4864e to 140429e Compare January 22, 2025 16:38
@yihau
Copy link
Member

yihau commented Jan 29, 2025

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/cargo/rocksdb-0.23.0 branch from f1aada0 to 9886d65 Compare January 29, 2025 03:23
dependabot bot and others added 3 commits February 10, 2025 17:52
@dependabot @yihau
build(deps): bump rocksdb from 0.22.0 to 0.23.0
c8a39d9 
Bumps [rocksdb](https://github.com/rust-rocksdb/rust-rocksdb) from 0.22.0 to 0.23.0.
- [Release notes](https://github.com/rust-rocksdb/rust-rocksdb/releases)
- [Changelog](https://github.com/rust-rocksdb/rust-rocksdb/blob/master/CHANGELOG.md)
- [Commits](rust-rocksdb/rust-rocksdb@v0.22.0...v0.23.0)

---
updated-dependencies:
- dependency-name: rocksdb
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @yihau
Update all Cargo files
94face1
@yihau
add libclang-dev to dockerfile
52ec340
@yihau yihau force-pushed the dependabot/cargo/rocksdb-0.23.0 branch 2 times, most recently from a3f8d50 to e2f922a Compare February 10, 2025 13:22
@yihau yihau mentioned this pull request Feb 10, 2025
Closed
@yihau yihau force-pushed the dependabot/cargo/rocksdb-0.23.0 branch from e2f922a to a32a243 Compare February 10, 2025 17:07
@ksolana
Copy link

ksolana commented Feb 10, 2025

Fixes #4892

@yihau yihau force-pushed the dependabot/cargo/rocksdb-0.23.0 branch 2 times, most recently from 9148512 to 58e301b Compare February 10, 2025 18:07
@yihau yihau force-pushed the dependabot/cargo/rocksdb-0.23.0 branch from 58e301b to 47f47e4 Compare February 10, 2025 18:11
@ksolana
Copy link

ksolana commented Feb 11, 2025

LGTM

@yihau yihau requested a review from steviez February 11, 2025 05:01
@steviez
Copy link

steviez commented Feb 11, 2025

For the sake of a paper-trail, what did you do to get CI passing ?

@yihau
Copy link
Member

yihau commented Feb 11, 2025

for Linux, I installed libclang-dev for our docker and Github Actions (credit goes to @ksolana)
for macOS, I installed and set the LLVM library path.
for Windows, I just used the default GitHub runner’s default environment

steviez
steviez approved these changes Feb 11, 2025
View reviewed changes
Copy link

@steviez steviez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through the PR's in rust-rocksdb (and upstream rocksdb) and nothing looked scary so LGTM. Given that we just cut v2.2, we'll also have a while to soak this with canaries.

As for the instructions on how to get CI passing / avoid build issues, good to know. I wouldn't be surprised if some people from the team run into this, so being able to point at this with some instructions should be helpful

@yihau yihau merged commit 2b0966d into master Feb 11, 2025
59 checks passed
@yihau yihau deleted the dependabot/cargo/rocksdb-0.23.0 branch February 11, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviez steviez steviez approved these changes

@ksolana ksolana ksolana approved these changes

@brooksprumo brooksprumo Awaiting requested review from brooksprumo

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihau @ksolana @steviez