v1.18: client: Timeout resends during send_and_confirm_in_parallel (backport of #358)
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* client: Timeout resends during `send_and_confirm_in_parallel` * Clarify constant (cherry picked from commit 36c66f5)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #384 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 827 827
Lines 224451 224458 +7
=======================================
+ Hits 183233 183240 +7
Misses 41218 41218 |
KirillLykov
approved these changes
Mar 22, 2024
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…(backport of anza-xyz#358) (anza-xyz#384) client: Timeout resends during `send_and_confirm_in_parallel` (anza-xyz#358) * client: Timeout resends during `send_and_confirm_in_parallel` * Clarify constant (cherry picked from commit 36c66f5) Co-authored-by: Jon C <me@jonc.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CLI sometimes gets stuck when deploying programs, as mentioned at #348 (comment)
Summary of Changes
The system for sending and confirming is properly updating the blockhash, and the resending task is checking that, so we're doing all the right things! Most likely, the system is getting stuck during the resend call, so the solution here is to timeout the resend.
I've also reduced the block height refresh time to 5 seconds, because it can be annoying to see nothing changing for a long time. I've also added in logging for the resending, that way it'll look to users that something is actually happening.
This is an automatic backport of pull request #358 done by [Mergify](https://mergify.com).