Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental arr.ai package to prototype standard Sysl transformations. #946

Merged
merged 6 commits into from
Jul 13, 2020

Conversation

orlade-anz
Copy link
Collaborator

@orlade-anz orlade-anz commented Jul 9, 2020

Changes proposed in this pull request:

  • Introduce new arr.ai package to prototype various Sysl transforms.

Checklist:

  • Added related tests
  • Made corresponding changes to the documentation

@orlade-anz orlade-anz added the WIP Work in progress label Jul 9, 2020
@orlade-anz orlade-anz marked this pull request as draft July 9, 2020 13:26
@orlade-anz orlade-anz removed the WIP Work in progress label Jul 9, 2020
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #946 into master will increase coverage by 0.78%.
The diff coverage is 83.88%.

@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
+ Coverage   83.35%   84.14%   +0.78%     
==========================================
  Files          73       74       +1     
  Lines       10609    10309     -300     
==========================================
- Hits         8843     8674     -169     
+ Misses       1432     1322     -110     
+ Partials      334      313      -21     
Impacted Files Coverage Δ
pkg/pbutil/output.go 76.00% <ø> (-0.48%) ⬇️
pkg/syslwrapper/test_helper.go 57.89% <ø> (-1.42%) ⬇️
pkg/parse/listener_impl.go 89.50% <61.53%> (+<0.01%) ⬆️
pkg/importer/importer.go 63.15% <63.15%> (ø)
pkg/mod/gomod.go 73.68% <66.66%> (+1.27%) ⬆️
pkg/parse/parse.go 83.47% <69.56%> (-0.50%) ⬇️
pkg/mod/module.go 66.66% <72.72%> (+0.95%) ⬆️
pkg/importer/formats.go 77.27% <77.27%> (ø)
pkg/importer/openapi.go 81.73% <80.71%> (-7.72%) ⬇️
pkg/importer/swagger.go 81.48% <88.88%> (+1.88%) ⬆️
... and 16 more

@orlade-anz orlade-anz self-assigned this Jul 9, 2020
@orlade-anz orlade-anz marked this pull request as ready for review July 9, 2020 13:35
@orlade-anz orlade-anz requested a review from nofun97 July 10, 2020 05:47
Copy link
Contributor

@cuminandpaprika cuminandpaprika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of minor suggestions

pkg/arrai/README.md Show resolved Hide resolved
pkg/arrai/model.sysl Show resolved Hide resolved
pkg/arrai/model.pb Show resolved Hide resolved
pkg/arrai/integration_diagram.md Show resolved Hide resolved
@orlade-anz orlade-anz merged commit b7780e7 into master Jul 13, 2020
@orlade-anz orlade-anz deleted the ladeo/arrai branch July 13, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants