Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#911 Enhance command sysl pb --mode=pb to output binary message #912

Merged
merged 8 commits into from
Jun 24, 2020

Conversation

ericzhang6222
Copy link
Contributor

  • Please attach WIP tag when this PR is still work in progress.
  • Please attach breaking-change tag if this PR potentially causes other components to fail or changes previous sysl executable's behaviour.

Fixes #911 .

Changes proposed in this pull request:

  • Enhance command sysl pb --mode=pb to output binary message

Checklist:

  • Added related tests
  • Made corresponding changes to the documentation

@ericzhang6222 ericzhang6222 marked this pull request as draft June 23, 2020 07:45
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #912 into master will increase coverage by 0.02%.
The diff coverage is 81.96%.

@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
+ Coverage   83.35%   83.37%   +0.02%     
==========================================
  Files          73       73              
  Lines       10609    10648      +39     
==========================================
+ Hits         8843     8878      +35     
- Misses       1432     1436       +4     
  Partials      334      334              
Impacted Files Coverage Δ
pkg/parse/listener_impl.go 89.59% <62.50%> (+0.08%) ⬆️
pkg/mod/gomod.go 73.68% <66.66%> (+1.27%) ⬆️
pkg/pbutil/output.go 76.00% <75.00%> (-0.48%) ⬇️
pkg/importer/openapi.go 88.95% <80.00%> (-0.50%) ⬇️
pkg/diagrams/diagutil.go 62.31% <100.00%> (ø)
pkg/importer/utils.go 88.23% <100.00%> (+0.35%) ⬆️
...g/mermaid/integrationdiagram/integrationdiagram.go 86.66% <100.00%> (+2.29%) ⬆️
pkg/mod/module.go 67.56% <100.00%> (+1.85%) ⬆️

@ericzhang6222 ericzhang6222 marked this pull request as ready for review June 23, 2020 08:58
cmd/sysl/cmd_protobuf.go Show resolved Hide resolved
pkg/pbutil/output.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@orlade-anz orlade-anz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

@ericzhang6222 ericzhang6222 requested a review from orlade-anz June 23, 2020 10:23
pkg/pbutil/output.go Outdated Show resolved Hide resolved
pkg/pbutil/output_test.go Outdated Show resolved Hide resolved
@ericzhang6222 ericzhang6222 requested a review from orlade-anz June 24, 2020 01:55
@ericzhang6222 ericzhang6222 merged commit 524f64b into master Jun 24, 2020
@ericzhang6222 ericzhang6222 deleted the pb_binary branch June 24, 2020 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMD protobuf can output binary message file
2 participants