Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for special characters in query params #871

Merged

Conversation

cuminandpaprika
Copy link
Contributor

@cuminandpaprika cuminandpaprika commented May 28, 2020

Enables the use of special characters such as - . etc in Query Param names

Fixes anz-bank/sysl-go#115

Changes proposed in this pull request:

  • Add support for special chars in query params

Checklist:

  • Added related tests
  • Made corresponding changes to the documentation

Enables the use of special characters such as - . etc in Query Param names
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #871 into master will not change coverage.
The diff coverage is 77.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #871   +/-   ##
=======================================
  Coverage   83.35%   83.35%           
=======================================
  Files          73       73           
  Lines       10609    10609           
=======================================
  Hits         8843     8843           
  Misses       1432     1432           
  Partials      334      334           
Impacted Files Coverage Δ
pkg/parse/listener_impl.go 89.50% <66.66%> (ø)
pkg/mermaid/datamodeldiagram/datamodeldiagram.go 58.57% <73.43%> (ø)
...endpointanalysisdiagram/endpointanalysisdiagram.go 82.97% <100.00%> (ø)
...g/mermaid/integrationdiagram/integrationdiagram.go 84.37% <100.00%> (ø)
pkg/mermaid/sequencediagram/sequencediagram.go 74.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75bd45a...81f47b6. Read the comment docs.

@cuminandpaprika cuminandpaprika marked this pull request as ready for review May 28, 2020 07:44
Copy link
Member

@nofun97 nofun97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cuminandpaprika cuminandpaprika merged commit ed4f32c into anz-bank:master May 28, 2020
@cuminandpaprika cuminandpaprika deleted the support-dash-query-param branch May 28, 2020 23:37
anzopensource pushed a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dash in the parameter name of the URL
2 participants