-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with equals
since 3.0.0 with fast-deep-equal
#52
Comments
silverwind
changed the title
Issue with
Issue with Jan 31, 2023
equals
since 3.0.0equals
since 3.0.0 with fast-deep-equal
Sorry about this. I will look into this module later today. I do have some equals working at the unit test level but not at scale. Very odd.
Sent from my T-Mobile 5G Device
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: silverwind ***@***.***>
Sent: Tuesday, January 31, 2023 7:24:42 AM
To: anywhichway/nano-memoize ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [anywhichway/nano-memoize] Issue with `equals` since 3.0.0 (Issue #52)
After upgrading from 2.0.0 to 3.0.1, various unit tests on memoized functions started to fail for me. I'm using fast-deep-equal<https://github.com/epoberezkin/fast-deep-equal> as the comparison function, e.g.:
nanomemoize(fn, {equals: deepEqual})
I see the README mentions this specific issue with other modules but does not mention this module yet, so I thought I mention it.
—
Reply to this email directly, view it on GitHub<#52>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABF2US4IVSV3NDUIE6BPEILWVEHBVANCNFSM6AAAAAAUMN2HRM>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
@silverwind I believe this is fixed. Please confirms with v3.0.2. |
Yes, thanks. My unit tests are working again with v3.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After upgrading from 2.0.0 to 3.0.1, various unit tests on memoized functions started to fail for me. I'm using fast-deep-equal as the comparison function, e.g.:
I see the README mentions this specific issue with other modules but does not mention this module yet, so I thought I mention it.
The text was updated successfully, but these errors were encountered: