Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with equals since 3.0.0 with fast-deep-equal #52

Closed
silverwind opened this issue Jan 31, 2023 · 3 comments
Closed

Issue with equals since 3.0.0 with fast-deep-equal #52

silverwind opened this issue Jan 31, 2023 · 3 comments

Comments

@silverwind
Copy link
Contributor

silverwind commented Jan 31, 2023

After upgrading from 2.0.0 to 3.0.1, various unit tests on memoized functions started to fail for me. I'm using fast-deep-equal as the comparison function, e.g.:

import fastDeepEqual from "fast-deep-equal";
import nanomemoize from "nano-memoize";

const memoFn = fn => nanomemoize(fn, {equals: fastDeepEqual});

I see the README mentions this specific issue with other modules but does not mention this module yet, so I thought I mention it.

@silverwind silverwind changed the title Issue with equals since 3.0.0 Issue with equals since 3.0.0 with fast-deep-equal Jan 31, 2023
@anywhichway
Copy link
Owner

anywhichway commented Jan 31, 2023 via email

@anywhichway
Copy link
Owner

@silverwind I believe this is fixed. Please confirms with v3.0.2.

@silverwind
Copy link
Contributor Author

Yes, thanks. My unit tests are working again with v3.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants