Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in vrgs function? #17

Closed
gregjacobs opened this issue May 26, 2020 · 2 comments
Closed

Bug in vrgs function? #17

gregjacobs opened this issue May 26, 2020 · 2 comments
Assignees

Comments

@gregjacobs
Copy link

On line 25 (https://github.com/anywhichway/nano-memoize/blob/master/index.js#L25), the code reads:

return i>=0 && i<s.indexOf(")" || s.indexOf("arguments")>=0);
//                            ^-- missing end parenthesis?

The inner expression as it is currently written (")" || s.indexOf("arguments")>=0) will always evaluate to ")"

anywhichway pushed a commit that referenced this issue May 26, 2020
@anywhichway anywhichway self-assigned this May 26, 2020
@anywhichway
Copy link
Owner

@gregjacobs Thank you so much!

@gregjacobs
Copy link
Author

Np! Hope you wrote a test for that guy? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants