This repository has been archived by the owner on Feb 25, 2019. It is now read-only.
Repair broken this reference in authorizedScope()
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EternalDeiwos – want to do the honors of merging this one since you discovered the problem? |
|
Would be happy to. |
EternalDeiwos
added a commit
that referenced
this pull request
Oct 18, 2015
…zed-scope Repair broken `this` reference in authorizedScope()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit changed
User.prototype.authorizedScopeto look up unrestricted scopes from the data store. This change wrapped athis._idin a new function, causing the references to that property to be undefined. This caused user role lookups to always result in an empty array, and therefore authorization requests including restricted scopes would issue tokens omitting those scopes. This PR fixes the problem.