Skip to content
This repository has been archived by the owner on Feb 25, 2019. It is now read-only.

Use ioredis #188

Merged
merged 3 commits into from
Aug 23, 2015
Merged

Use ioredis #188

merged 3 commits into from
Aug 23, 2015

Conversation

adalinesimonian
Copy link
Member

Overview

To do

  1. Review Use ioredis modinha-redis#8
  2. Review this PR
  3. Merge Use ioredis modinha-redis#8
  4. Document changes in modinha-redis
  5. Release new modinha-redis version
  6. In this branch, update package.json to depend on new modinha-redis version
  7. Re-test this PR
  8. Merge this PR
  9. Document changes
  10. Release new anvil-connect version

Details

Local tests:

  • All 891 unit tests pass
  • All 228 integration tests pass
  • Manually verified application works as expected

Implications:

  • Unit and integration tests separated within test folder
  • Only unit tests are run by npm test, integration tests must be run manually (as they require a working, configured instance)
  • Usage of redis and mailer modules now requires calling .getClient() and .getMailer() respectively
  • Redis configuration in config file now follows the same format used by ioredis
  • We need to make the logger module follow the same configuration pattern that redis and mailer now follow

@adalinesimonian
Copy link
Member Author

Soliciting @christiansmith's help with review.

@christiansmith
Copy link
Member

Excellent work, @vsimonian! Can't wait to merge this after we review.

christiansmith added a commit that referenced this pull request Aug 23, 2015
@christiansmith christiansmith merged commit ee3e79c into master Aug 23, 2015
@adalinesimonian adalinesimonian deleted the vsimonian-ioredis branch August 23, 2015 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants