Accessibility fixes for generated documentation #397
Conversation
|
@benogle what do you think about this? |
| @@ -231,7 +231,7 @@ $background-arguments: #fafbfc; | |||
| .sidebar-open-button { | |||
| &::after { | |||
| display: block; | |||
| content: "All Topics"; | |||
| content: "All topics"; | |||
There was a problem hiding this comment.
Mind keeping this the way it was? you should be able to override the content with CSS.
| @@ -387,7 +387,7 @@ $background-arguments: #fafbfc; | |||
| .operation-description > h5, | |||
| .definition-description > h5, | |||
| .definition-properties > h5 { | |||
| display: none; | |||
| @include visually-hidden(); | |||
There was a problem hiding this comment.
Looks like this one is in the spectaql theme as well. Can you add that one and test it too?
There was a problem hiding this comment.
(meaning src/themes/spectaql/*)
|
Hi I updated the spectaql theme and changed back the ::after text Is "All topics" ok for the sr only text? Seems like you've gone that way with the "Close menu" aria-label Thanks |
|
bump @benogle |
Yep, all good 👍 |
|
Thank you we were wondering if you had a timeline for when you will release those changes? |
|
Thanks @simoncoggins and @jackrhumphrey ! This is out in v |
Fixes #396