adding api to enable file logging. adding reapply to bios_boot_oder (C…

…iscoUcs#91) Signed-off-by: vvb <vvb@cisco.com>
anuvu · Jan 18, 2017 · 9863459 · 9863459
1 parent b0bfde5
commit 9863459
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 7 deletions.
diff --git a/imcsdk/__init__.py b/imcsdk/__init__.py
@@ -13,6 +13,7 @@
 
 
 import logging
+import logging.handlers
 
 log = logging.getLogger('imc')
 console = logging.StreamHandler()
@@ -21,6 +22,12 @@
 console.setFormatter(formatter)
 
 
+def enable_file_logging(filename="imcsdk.log"):
+    file_handler = logging.handlers.RotatingFileHandler(
+              filename, maxBytes=10*1024*1024, backupCount=5)
+    log.addHandler(file_handler)
+
+
 def set_log_level(level=logging.DEBUG):
     """
     Allows setting log level

diff --git a/imcsdk/apis/server/bios.py b/imcsdk/apis/server/bios.py
@@ -205,8 +205,12 @@ def _add_boot_device(handle, parent_dn, boot_device):
 
 
 def boot_order_precision_set(
-        handle, reboot_on_update=False, configured_boot_mode="Legacy",
-        boot_devices=[], server_id=1):
+        handle,
+        reboot_on_update=False,
+        reapply=False,
+        configured_boot_mode="Legacy",
+        boot_devices=[],
+        server_id=1):
     """
     This method will replace the existing boot order precision with the new one
         and also set the boot mode
@@ -215,6 +219,7 @@ def boot_order_precision_set(
     Args:
         handle (ImcHandle)
         reboot_on_update (bool): True, False
+        reapply(bool): True, False
         configured_boot_mode(string): "Legacy", "Uefi", "None"
         boot_devices (list of dict): format
             [{"order":'1', "device-type":"vmedia", "name":"vmedia"},
@@ -234,10 +239,11 @@ def boot_order_precision_set(
     Examples:
         boot_order_precision_set(
             handle,
-             reboot_on_update=False,
-             configured_boot_mode="Uefi",
-             boot_devices = [{"order":'1', "device-type":"vmedia", "name":"vmedia"},
-                             {"order":'2', "device-type":"hdd", "name":"hdd"}]
+            reboot_on_update=False,
+            reapply=False,
+            configured_boot_mode="Uefi",
+            boot_devices = [{"order":'1', "device-type":"vmedia", "name":"vmedia"},
+                            {"order":'2', "device-type":"hdd", "name":"hdd"}]
     """
 
     # Insert version check here to gracefully handle older versions of CIMC
@@ -247,12 +253,15 @@ def boot_order_precision_set(
 
     server_dn = imccoreutils.get_server_dn(handle, server_id)
     lsbootdevprecision_mo = LsbootDevPrecision(parent_mo_or_dn=server_dn)
-    # lsbootdevprecision_mo.reboot_on_update = ("no", "yes")[reboot_on_update]
 
     lsbootdevprecision_mo.reboot_on_update = "no"
     if reboot_on_update:
         lsbootdevprecision_mo.reboot_on_update = "yes"
 
+    lsbootdevprecision_mo.reapply = "no"
+    if reapply:
+        lsbootdevprecision_mo.reapply = "yes"
+
     lsbootdevprecision_mo.configured_boot_mode = configured_boot_mode
 
     handle.set_mo(lsbootdevprecision_mo)