add percentile rank icon and remove progress #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2859 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 24 24
Lines 5088 5094 +6
Branches 452 452
=======================================
+ Hits 4972 4978 +6
Misses 115 115
Partials 1 1
☔ View full report in Codecov by Sentry. |
2881194 to
ee04e5f
Compare
ee04e5f to
08497e2
Compare
This commit adds the `percentile` option for the `rank_icon` query variable. This option displays the rank percentile the user belongs to.
08497e2 to
c48c847
Compare
rickstaa
commented
Jun 19, 2023
src/common/icons.js
Outdated
| `; | ||
| case "percentile": | ||
| return ` | ||
| <text x="-5" y="-12" alignment-baseline="central" dominant-baseline="central" text-anchor="middle" data-testid="percentile-top-header" class="rank-percentile-header"> |
There was a problem hiding this comment.
The y values were chosen after a quick look. It could be that these could be improved to align the header and value better.
e942ad0 to
3de7ab4
Compare
This was referenced Jun 19, 2023
Closed
qwerty541
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
@qwerty541 let me know what you think. We can also replace the
progressoption that was merged, but maybe having both options would be nice. I'm not yet sure 🤔 .
I agree with the @MindLaborDev's point of view explained in #2858 (comment) that it is impossible to understand what the percentile means for random profile visitors. I think that it is better to overwrite the progress option because very little time has passed since merge of #2858 and most likely no one is using it yet, except @silverwind who needs to be warned.
I have updated the code a little, please check it and feel free to merge.
HackingGate
pushed a commit
to HackingGate/github-readme-stats
that referenced
this pull request
Jun 25, 2023
* feat: add 'percentile' rank icon This commit adds the `percentile` option for the `rank_icon` query variable. This option displays the rank percentile the user belongs to. * style: improve percentile rank icon styling * dev * dev * dev --------- Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
devantler
pushed a commit
to devantler/github-readme-stats
that referenced
this pull request
Sep 24, 2023
* feat: add 'percentile' rank icon This commit adds the `percentile` option for the `rank_icon` query variable. This option displays the rank percentile the user belongs to. * style: improve percentile rank icon styling * dev * dev * dev --------- Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
setdebarr
pushed a commit
to setdebarr/github-readme-stats
that referenced
this pull request
Jan 12, 2024
* feat: add 'percentile' rank icon This commit adds the `percentile` option for the `rank_icon` query variable. This option displays the rank percentile the user belongs to. * style: improve percentile rank icon styling * dev * dev * dev --------- Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
jacobbexten
pushed a commit
to jacobbexten/github-readme-stats
that referenced
this pull request
Nov 6, 2024
* feat: add 'percentile' rank icon This commit adds the `percentile` option for the `rank_icon` query variable. This option displays the rank percentile the user belongs to. * style: improve percentile rank icon styling * dev * dev * dev --------- Co-authored-by: Alexandr <qwerty541zxc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
percentileoption for therank_iconquery variable. This option displays the rank percentile the user belongs to. See #2858 (comment).@qwerty541 let me know what you think. We can also replace the
progressoption that was merged, but maybe having both options would be nice. I'm not yet sure 🤔 .