-
-
Notifications
You must be signed in to change notification settings - Fork 23.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add traditional Chinese (zh-tw) #1238
Conversation
Add traditional Chinese (zh-tw)
@ItzMiracleOwO is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
@@ -84,6 +87,7 @@ const statCardLocales = ({ name, apostrophe }) => { | |||
"statcard.prs": { | |||
ar: "مجموع طلبات السحب", | |||
cn: "拉取请求数(PR)", | |||
"zh-tw": "拉取請求數(PR)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ItzMiracleOwO Thanks a lot for your contribution. I don't speak traditional Chinese, but the translations look good in google translate. Is there a language syntax reason you added an extra space at the end of the statcard.prs
and statcard.commits
. If not, please remove these extra spaces to merge this pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
Just adding spaces before and after brackets so that the words would seemed seperated on the card, we usually do the same in documents to make it look better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ItzMiracleOwO Ah, I see. Thanks a lot for the explanation. In that case, the PR looks good to me. Thanks a lot for your contribution.
@@ -58,6 +60,7 @@ const statCardLocales = ({ name, apostrophe }) => { | |||
"statcard.commits": { | |||
ar: "مجموع الحفظ", | |||
cn: "累计提交数(commit)", | |||
"zh-tw": "累計提交數(commit)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment below
Add traditional Chinese (zh-tw)
Add traditional Chinese (zh-tw)
Add traditional Chinese (zh-tw)