feat: ⚡️ support html source code of examples #83

afc163 · 2019-12-16T10:31:40Z

close #74

需要修改 gatsby-config.js:

gatsby-theme-antv/example/gatsby-config.js

Lines 87 to 101 in 8585ccf

    
                 htmlCodeTemplate: `<!DOCTYPE html> 
        
           <html> 
        
             <head> 
        
               <meta charset="UTF-8"> 
        
               <title>{{title}}</title> 
        
             </head> 
        
             <body> 
        
               <div id="container" /> 
        
               <script src="https://gw.alipayobjects.com/os/antv/pkg/_antv.g2-3.5.1/dist/g2.min.js"></script> 
        
               <script src="https://gw.alipayobjects.com/os/antv/pkg/_antv.data-set-0.10.1/dist/data-set.min.js"></script> 
        
               <script> 
        
           {{code}} 
        
               </script> 
        
             </body> 
        
           </html>`,

close #74

tests-checker

Could you please add tests to make sure this change works as expected?

netlify · 2019-12-16T10:31:48Z

Deploy preview for gatsby-theme-antv ready!

Built with commit 80cf6b5

https://deploy-preview-83--gatsby-theme-antv.netlify.com

afc163 · 2019-12-16T10:44:41Z

gatsby-theme-antv@0.10.20

⚡ support html source code of examples

8585ccf

close #74

auto-add-label bot added the enhancement New feature or request label Dec 16, 2019

pr-triage bot added the PR: unreviewed label Dec 16, 2019

tests-checker bot suggested changes Dec 16, 2019

View reviewed changes

pr-triage bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Dec 16, 2019

✅ fix eslint

80cf6b5

pr-triage bot added PR: unreviewed and removed PR: reviewed-changes-requested labels Dec 16, 2019

afc163 merged commit d854bbe into master Dec 16, 2019

afc163 deleted the example-html-template branch December 16, 2019 10:44

pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 16, 2019

afc163 mentioned this pull request Dec 24, 2019

AntV 官网改造 antvis/antvis.github.io#18

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ⚡️ support html source code of examples #83

feat: ⚡️ support html source code of examples #83

afc163 commented Dec 16, 2019 •

edited

Loading

tests-checker bot left a comment

netlify bot commented Dec 16, 2019 •

edited

Loading

afc163 commented Dec 16, 2019

	htmlCodeTemplate: `<!DOCTYPE html>
	<html>
	<head>
	<meta charset="UTF-8">
	<title>{{title}}</title>
	</head>
	<body>
	<div id="container" />
	<script src="https://gw.alipayobjects.com/os/antv/pkg/_antv.g2-3.5.1/dist/g2.min.js"></script>
	<script src="https://gw.alipayobjects.com/os/antv/pkg/_antv.data-set-0.10.1/dist/data-set.min.js"></script>
	<script>
	{{code}}
	</script>
	</body>
	</html>`,

feat: ⚡️ support html source code of examples #83

feat: ⚡️ support html source code of examples #83

Conversation

afc163 commented Dec 16, 2019 • edited Loading

tests-checker bot left a comment

Choose a reason for hiding this comment

netlify bot commented Dec 16, 2019 • edited Loading

afc163 commented Dec 16, 2019

afc163 commented Dec 16, 2019 •

edited

Loading

netlify bot commented Dec 16, 2019 •

edited

Loading