feat(scatter): 散点图支持color和shape同时映射图例字段 & 添加单测 #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
approved these changes
Mar 9, 2021
hustcc
reviewed
Mar 9, 2021
02b7604 to
f47bf6a
Compare
* feat(scatter): 散点图支持配置 shapeLegend & sizeLegend * test(scatter-legend): 增加散点图图例用例（shapeLegend、sizeLegend） Co-authored-by: visiky <736929286@qq.com> Co-authored-by: elvira.zy <elvira.zy@alibaba-inc.com>
默认配置 legend 时，展示 color 图例和 shape 图例 当 shapeLegend 为 false，强制关闭 shape 图例 shape 为 undefined 时，默认不会展示 shape 图例
|
本地 CI 已过 |
elvira1112
approved these changes
Mar 22, 2021
| if (shapeLegend) { | ||
| chart.legend(shapeField, shapeLegend); | ||
| } else { | ||
| chart.legend(shapeField, shapeLegend === false ? false : legend); |
There was a problem hiding this comment.
shapeLegend 为 undefined 的时候，showShapeLegend 为不显示，但这边却进到了 chart.legend(shapeField, legend); 的逻辑里。
- 其实不考虑兼容的话 chart.legend(shapeField, options.hasOwnProperty('shapeLegend') ? shapeLegend : legend) 就好了；
- 现在 colorField = undefined， legend = {} 的话，chart.legend() 没有一个函数能进，不确定对不对，感觉至少要触发 chart.legend(false)
There was a problem hiding this comment.
“现在 colorField = undefined， legend = {} 的话，chart.legend() 没有一个函数能进” 不是的，可以看下使用文档
hustcc
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
Screenshot