test(scatter-legend): 增加散点图图例用例（shapeLegend、sizeLegend） #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visiky
approved these changes
Mar 22, 2021
visiky
added a commit
that referenced
this pull request
Mar 22, 2021
* feat(scatter): 散点图支持配置 shapeLegend & sizeLegend * test(scatter-legend): 增加散点图图例用例（shapeLegend、sizeLegend） Co-authored-by: visiky <736929286@qq.com> Co-authored-by: elvira.zy <elvira.zy@alibaba-inc.com>
hustcc
pushed a commit
that referenced
this pull request
Mar 23, 2021
* feat(scatter): 散点图支持color和shape同时映射图例字段 & 添加单测 * feat(scatter): 散点图支持配置 shapeLegend & sizeLegend * test(scatter-legend): 增加散点图图例用例（shapeLegend、sizeLegend） (#2446) * feat(scatter): 散点图支持配置 shapeLegend & sizeLegend * test(scatter-legend): 增加散点图图例用例（shapeLegend、sizeLegend） Co-authored-by: visiky <736929286@qq.com> Co-authored-by: elvira.zy <elvira.zy@alibaba-inc.com> * fix(scatter): 优化散点图图例逻辑 默认配置 legend 时，展示 color 图例和 shape 图例 当 shapeLegend 为 false，强制关闭 shape 图例 shape 为 undefined 时，默认不会展示 shape 图例 * docs(scatter-legend): 散点图图例文档 * fix: 修改 cr 建议 * fix: cr 建议 Co-authored-by: elvira1112 <ranxi1112@gmail.com> Co-authored-by: elvira.zy <elvira.zy@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
Screenshot