Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: antv.vision #42

Merged
merged 2 commits into from
Nov 21, 2019
Merged

feat: antv.vision #42

merged 2 commits into from
Nov 21, 2019

Conversation

afc163
Copy link
Contributor

@afc163 afc163 commented Nov 20, 2019

#18

@pr-triage pr-triage bot added the PR: draft label Nov 20, 2019
tests-checker[bot]
tests-checker bot suggested changes Nov 20, 2019
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@pr-triage pr-triage bot removed the PR: draft label Nov 20, 2019
@afc163
Copy link
Contributor Author

afc163 commented Nov 20, 2019

/rebase

@netlify
Copy link

netlify bot commented Nov 20, 2019 •
edited
Loading

Deploy preview for hardcore-feynman-614fe6 ready!

Built with commit f8bb364

https://deploy-preview-42--hardcore-feynman-614fe6.netlify.com

@afc163 afc163 marked this pull request as ready for review November 21, 2019 11:21
@Yanyan-Wang Yanyan-Wang changed the title 🚀 antv.vision feat:🚀 antv.vision Nov 21, 2019
@Yanyan-Wang Yanyan-Wang changed the title feat:🚀 antv.vision feat:antv.vision Nov 21, 2019
@Yanyan-Wang Yanyan-Wang changed the title feat:antv.vision fix.vision Nov 21, 2019
@Yanyan-Wang Yanyan-Wang changed the title fix.vision fix:vis.vision Nov 21, 2019
@Yanyan-Wang Yanyan-Wang changed the title fix:vis.vision fix(fix):antv.vision Nov 21, 2019
@Yanyan-Wang Yanyan-Wang changed the title fix(fix):antv.vision feat: antv.vision Nov 21, 2019
@Yanyan-Wang Yanyan-Wang merged commit 55405a4 into develop Nov 21, 2019
@Yanyan-Wang Yanyan-Wang deleted the antv.vision branch November 21, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
enhancement PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afc163 @Yanyan-Wang