chore: release graphin 2.1.0 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pomelo-nwu
commented
Jul 14, 2021
- Update g6 version to 4.3.4
- Fix Legend component logic
- Lock fatherjs version
- Fix Hull Components uuid issue
- Fix site undefined url
- Feat:add CreateEdge component
line149 函数注释与实际参数不一致 changedFiled -> changedField
chore(🆙): Upgrade React to v17.0.1
docs: fix typo [changedFiled]
xdddst
reviewed
Jul 14, 2021
| @@ -35,7 +35,7 @@ export type ValuesOf<T extends any[]> = T[number]; | |||
|
|
|||
| export const getProducts = ({ | |||
| t, | |||
| language, | |||
| language = 'zh', | |||
| import Graphin, { Utils } from '@antv/graphin'; | ||
| import React from 'react'; |
| const { options } = props; | ||
|
|
||
| hullInstances = options.map((item) => { | ||
| return graph.createHull(deepMergeCfg(defaultHullCfg, item)); | ||
| hullInstances = options.map(item => { |
There was a problem hiding this comment.
这里需要加下过滤，如果传入的members的id中在画布中实际不存在，会导致报错。
| @@ -93,7 +116,7 @@ const Hull: React.FunctionComponent<IHullProps> = (props) => { | |||
| return () => { | |||
| graph.on('afterupdateitem', handleAfterUpdateItem); | |||
| }; | |||
| }, []); | |||
| }, [graph]); | |||
|
|
|||
| return <div className="graphin-hull-container" />; | |||
There was a problem hiding this comment.
这个文件里没有看到有监听options的变化，如果options变了，是不是需要移除原有的轮廓、重新绘制呢
xdddst
reviewed
Jul 14, 2021
| import React from 'react'; | ||
|
|
||
| // @ts-ignore | ||
| import { GraphinContext } from '@antv/graphin'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.