Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue-3012): 修复条形图图例转置 & 单测 #3013

Merged
merged 2 commits into from
Dec 9, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
146 changes: 146 additions & 0 deletions __tests__/bugs/issue-3012-spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
import { Bar } from '../../src';
import { createDiv } from '../utils/dom';
import { delay } from '../utils/delay';

describe('#3012', () => {
it('basic bar', async () => {
const data = [
{ year: '1951 年', value: 38 },
{ year: '1952 年', value: 52 },
{ year: '1956 年', value: 61 },
{ year: '1957 年', value: 145 },
{ year: '1958 年', value: 48 },
];

const bar = new Bar(createDiv(), {
data,
xField: 'value',
yField: 'year',
seriesField: 'year',
legend: {
position: 'top-left',
},
});

bar.render();
const legendItems = bar.chart.getController('legend').getComponents()[0].component.get('items');
expect(legendItems.length).toBe(data.length);
expect(legendItems[0].name).toBe(data[0].year);

const tooltipController = bar.chart.getController('tooltip');
const box = bar.chart.geometries[0].elements[0].shape.getBBox();
const point = { x: box.x + box.width / 2, y: box.y + box.height / 2 };

await delay(80);
bar.chart.showTooltip(point);
await delay(100);

const items = tooltipController.getTooltipItems(point);
expect(items[0].name).toBe(data[0].year);

bar.destroy();
});

it('group bar & stack bar', async () => {
const data = [
{
label: 'Mon.',
type: 'series1',
value: 2800,
},
{
label: 'Mon.',
type: 'series2',
value: 2260,
},
{
label: 'Tues.',
type: 'series1',
value: 1800,
},
{
label: 'Tues.',
type: 'series2',
value: 1300,
},
{
label: 'Wed.',
type: 'series1',
value: 950,
},
{
label: 'Wed.',
type: 'series2',
value: 900,
},
{
label: 'Thur.',
type: 'series1',
value: 500,
},
{
label: 'Thur.',
type: 'series2',
value: 390,
},
{
label: 'Fri.',
type: 'series1',
value: 170,
},
{
label: 'Fri.',
type: 'series2',
value: 100,
},
];

const bar = new Bar(createDiv(), {
data,
isGroup: true,
xField: 'value',
yField: 'label',
seriesField: 'type',
legend: {
position: 'top-left',
},
});

bar.render();
let legendItems = bar.chart.getController('legend').getComponents()[0].component.get('items');
expect(legendItems.length).toBe(2);
expect(legendItems[0].name).toBe('series1');
expect(legendItems[1].name).toBe('series2');

const tooltipController = bar.chart.getController('tooltip');
let box = bar.chart.geometries[0].elements[0].shape.getBBox();
let point = { x: box.x + box.width / 2, y: box.y + box.height / 2 };

await delay(80);
bar.chart.showTooltip(point);
await delay(100);

let items = tooltipController.getTooltipItems(point);
expect(items[0].name).toBe('series1');
expect(items[1].name).toBe('series2');

bar.update({ isGroup: false, isStack: true });
legendItems = bar.chart.getController('legend').getComponents()[0].component.get('items');
expect(legendItems.length).toBe(2);
expect(legendItems[0].name).toBe('series1');
expect(legendItems[1].name).toBe('series2');

box = bar.chart.geometries[0].elements[0].shape.getBBox();
point = { x: box.x + box.width / 2, y: box.y + box.height / 2 };

await delay(80);
bar.chart.showTooltip(point);
await delay(100);

items = tooltipController.getTooltipItems(point);
expect(items[0].name).toBe('series1');
expect(items[1].name).toBe('series2');

bar.destroy();
});
});
25 changes: 1 addition & 24 deletions src/plots/bar/adaptor.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Params } from '../../core/adaptor';
import { tooltip } from '../../adaptor/common';
import { deepAssign, flow } from '../../utils';
import { adaptor as columnAdaptor } from '../column/adaptor';
export { meta } from '../column/adaptor';
Expand Down Expand Up @@ -83,7 +84,6 @@ function legend(params: Params<BarOptions>): Params<BarOptions> {
if (legend !== false) {
legend = {
position: isStack ? 'top-left' : 'right-top',
reversed: isStack ? false : true,
...(legend || {}),
};
}
Expand All @@ -94,29 +94,6 @@ function legend(params: Params<BarOptions>): Params<BarOptions> {
return deepAssign({}, params, { options: { legend } });
}

/**
* tooltip 适配器
* @param params
*/
function tooltip(params: Params<BarOptions>): Params<BarOptions> {
const { options } = params;

// 默认 legend 位置
const { seriesField, isStack } = options;
// 默认 tooltip 配置
let { tooltip } = options;
if (seriesField) {
if (tooltip !== false) {
tooltip = {
reversed: isStack ? false : true,
...(tooltip || {}),
};
}
}

return deepAssign({}, params, { options: { tooltip } });
}

/**
* coordinate 适配器
* @param params
Expand Down