Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esm): remove all the lib import #2131

Merged
merged 5 commits into from
Dec 23, 2020
Merged

fix(esm): remove all the lib import #2131

merged 5 commits into from
Dec 23, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Dec 21, 2020

PR includes

  • fixed esm issues

Screenshot

Before After

总体降低包大小 150 kb(之前是 950 kb)

image

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2020

😭 Deploy PR Preview 7ae4aa3 failed. Build logs

🤖 By surge-preview

@lgtm-com
Copy link

lgtm-com bot commented Dec 21, 2020

This pull request fixes 1 alert when merging 649c437 into 19e7e1c - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 21, 2020

This pull request fixes 1 alert when merging 688f3e9 into 19e7e1c - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2020

This pull request fixes 1 alert when merging 05e2987 into 7394274 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@coveralls
Copy link

coveralls commented Dec 23, 2020

Pull Request Test Coverage Report for Build 439594283

  • 21 of 21 (100.0%) changed or added relevant lines in 17 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 96.746%

Files with Coverage Reduction New Missed Lines %
src/adaptor/conversion-tag.ts 2 92.54%
src/utils/statistic.ts 4 90.97%
Totals Coverage Status
Change from base Build 434775873: 0.0%
Covered Lines: 4369
Relevant Lines: 4407

💛 - Coveralls

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2020

This pull request fixes 1 alert when merging 7ae4aa3 into 7394274 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@hustcc hustcc merged commit 1753089 into master Dec 23, 2020
@hustcc hustcc deleted the fix-esm branch December 23, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants