-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add plot chord (增加弦图) #2073
Conversation
MrSmallLiu
commented
Dec 4, 2020
•
edited
Loading
edited
- adaptor
- tests
- docs
- example
@MrSmallLiu 感谢感谢,可以加我钉钉,我拉你进开发群。 我的钉钉 hustcc 。 |
Pull Request Test Coverage Report for Build 429810100
💛 - Coveralls |
主要三个大问题需要考虑:
|
看下 highcharts 的 和弦图,应该数据结构是和桑基图一致的 |
竞品里面有做 sourceWeightField&targetWeightField 的吗?如果没有那就先只做 weightField,后面有真正的业务场景在做 sourceWeightField&targetWeightField,不能因为技术上有这个能力,就一定要暴露出来。 |
合并master
和弦图配置修改与桑基图一致; 增加tanformDataToNodeLinkData让和弦图、桑基图复用,同时增加单测;
代码上我感觉问题不大了,剩下的可以吧单测多搞搞了。 |