[FlowAggregator] Use correct input channel in flowExportLoopProxy #6990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was invalid as the function was consuming messages straight from the collector instead of from the preprocessor, hence bypasing the preprocessor. This was not caught by e2e tests because the preprocessor output channel is small (capacity of 16), hence it was filling up very quickly and only a few uninteresting (i.e., irrelevant to the test cases) records were lost. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
luolanzone
approved these changes
Feb 12, 2025
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was invalid as the function was consuming messages straight from the collector instead of from the preprocessor, hence bypasing the preprocessor. This was not caught by e2e tests because the preprocessor output channel is small (capacity of 16), hence it was filling up very quickly and only a few uninteresting (i.e., irrelevant to the test cases) records were lost.