Remove additional deprecated CRD apis #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbd55b to
e2ffd23
Compare
This is a follow-up to antrea-io#6162 We remove the following APIs in preparation for Antrea v2: v1alpha3.ClusterGroup, v1alpha3.Group, v1alpha2.ExternalIPPool. All 3 of them are Alpha APIs which have been deprecated since Antrea v1.13. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
It should have been v1beta1 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
e2ffd23 to
09b26b2
Compare
While the API was not officially marked as deprecated in the documentation (docs/api.md), we did mention its deprecation in the CHANGELOG for the 1.13 release. It makes sense to delete this API at the same time as the other deprecated Alpha APIs, for Antrea 2.0. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
09b26b2 to
a42b0a1
Compare
luolanzone
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
LGTM, @edwardbadboy could you also take a look at this and make sure there is no impact to your side if we remove all deprecated APIs? Thanks.
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6162
We remove the following APIs in preparation for Antrea v2:
v1alpha3.ClusterGroup, v1alpha3.Group, v1alpha2.ExternalIPPool.
All 3 of them are Alpha APIs which have been deprecated since Antrea v1.13.