Request basic memory for antrea-controller #6233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with K8s v1.22, system-cluster-critical Pods no longer get low OOM score like system-node-critical Pods. antrea-controller's OOM score adjustment was changed from -997 to 999 passively, which made it just have a bit higher chance of survival over best-effort Pods (OOM score adjustment: 1000). While it's hard to say how much memory it can use as it's highly related to the scale of the cluster, we can add a basic memory request which can decrease the score a bit according to the formula for burstable Pods: oomScoreAdjust := 1000 - (1000*memoryRequest)/memoryCapacity It should also be a bit helpful to avoid antrea-controller to be scheduled on a Node with very few available memory. Signed-off-by: Quan Tian <quan.tian@broadcom.com>
0ab884c to
786582f
Compare
antoninbas
approved these changes
Apr 17, 2024
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with K8s v1.22, system-cluster-critical Pods no longer get low OOM score like system-node-critical Pods. antrea-controller's OOM score adjustment was changed from -997 to 999 passively, which made it just have a bit higher chance of survival over best-effort Pods (OOM score adjustment: 1000). While it's hard to say how much memory it can use as it's highly related to the scale of the cluster, we can add a basic memory request which can decrease the score a bit according to the formula for burstable Pods:
oomScoreAdjust := 1000 - (1000*memoryRequest)/memoryCapacity
It should also be a bit helpful to avoid antrea-controller to be scheduled on a Node with very few available memory.