Fix a flaky failure in VM Agent e2e test "testExternalNode" #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-vm-e2e |
|
/test-all |
|
/test-vm-e2e |
2 similar comments
|
/test-vm-e2e |
|
/test-vm-e2e |
The failure occurs when the check is performed before the default route on the uplink is removed, then two interfaces are found, which leads to a mismatch with the expectation. The fix is to introduce a retry when checking the VM network configurations, and and a check on the count of the default route before return. Signed-off-by: Wenying Dong <wenyingd@vmware.com>
|
/test-vm-e2e |
luolanzone
approved these changes
Apr 2, 2024
|
/skip-conformance |
|
@tnqn @luolanzone Thanks for reviewing and merging it. May I know if we need to back port it or not? |
We can backport to 1.14 and 1.15 if it helps stablize e2e tests. |
wenyingd
added a commit
to wenyingd/antrea
that referenced
this pull request
Apr 3, 2024
…o#6154) The failure occurs when the check is performed before the default route on the uplink is removed, then two interfaces are found, which leads to a mismatch with the expectation. The fix is to introduce a retry when checking the VM network configurations, and add a check on the count of the default route before return. Signed-off-by: Wenying Dong <wenyingd@vmware.com>
wenyingd
added a commit
to wenyingd/antrea
that referenced
this pull request
Apr 3, 2024
…o#6154) The failure occurs when the check is performed before the default route on the uplink is removed, then two interfaces are found, which leads to a mismatch with the expectation. The fix is to introduce a retry when checking the VM network configurations, and add a check on the count of the default route before return. Signed-off-by: Wenying Dong <wenyingd@vmware.com>
wenyingd
added a commit
to wenyingd/antrea
that referenced
this pull request
Apr 3, 2024
…o#6154) The failure occurs when the check is performed before the default route on the uplink is removed, then two interfaces are found, which leads to a mismatch with the expectation. The fix is to introduce a retry when checking the VM network configurations, and add a check on the count of the default route before return. Signed-off-by: Wenying Dong <wenyingd@vmware.com>
wenyingd
added a commit
to wenyingd/antrea
that referenced
this pull request
Apr 3, 2024
…o#6154) The failure occurs when the check is performed before the default route on the uplink is removed, then two interfaces are found, which leads to a mismatch with the expectation. The fix is to introduce a retry when checking the VM network configurations, and add a check on the count of the default route before return. Signed-off-by: Wenying Dong <wenyingd@vmware.com>
wenyingd
added a commit
to wenyingd/antrea
that referenced
this pull request
Apr 3, 2024
…o#6154) The failure occurs when the check is performed before the default route on the uplink is removed, then two interfaces are found, which leads to a mismatch with the expectation. The fix is to introduce a retry when checking the VM network configurations, and add a check on the count of the default route before return. Signed-off-by: Wenying Dong <wenyingd@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
Apr 3, 2024
…6184) The failure occurs when the check is performed before the default route on the uplink is removed, then two interfaces are found, which leads to a mismatch with the expectation. The fix is to introduce a retry when checking the VM network configurations, and add a check on the count of the default route before return. Signed-off-by: Wenying Dong <wenyingd@vmware.com>
tnqn
pushed a commit
that referenced
this pull request
Apr 3, 2024
…6185) The failure occurs when the check is performed before the default route on the uplink is removed, then two interfaces are found, which leads to a mismatch with the expectation. The fix is to introduce a retry when checking the VM network configurations, and add a check on the count of the default route before return. Signed-off-by: Wenying Dong <wenyingd@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure occurs when the check is performed before the default route on the uplink is removed, then two interfaces are found, which leads to a mismatch with the expectation.
The fix is to introduce a retry when checking the VM network configurations, and and a check on the count of the default route before return.
Fix: #6147