Automated cherry pick of #5409: Enable IPv6 on OVS internal port if needed in bridging mode #5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
The uplink interface may have an IPv6 address, while the interface created by OVS for the internal port may not support IPv6. For example, such a situation has been observed in a Kind cluster, with IPv6 enabled on the uplink but disbled by default on new interfaces: ``` root@kind-worker:/# sysctl net.ipv6.conf.all.disable_ipv6 net.ipv6.conf.all.disable_ipv6 = 1 root@kind-worker:/# sysctl net.ipv6.conf.default.disable_ipv6 net.ipv6.conf.default.disable_ipv6 = 1 root@kind-worker:/# sysctl net.ipv6.conf.eth0.disable_ipv6 net.ipv6.conf.eth0.disable_ipv6 = 0 ``` When we detect that uplink addresses include an IPv6 address, we will now ensure that IPv6 is enabled on the bridge port (using sysctl), before attempting to move the addresses over. If it fails, we will proceed with the rest of the initialization, but moving the IP addresses to the bridge is very likely to be unsuccessful in that case. We also make bridge cleanup more robust, by saving all uplink IP addresses in the uplink config, and using the saved values to restore the uplink interface. This ensures that cleanup can succeed, even if bridge configuration failed half-way, as was the case in antrea-io#5368. Fixes antrea-io#5368 Signed-off-by: Antonin Bas <abas@vmware.com>
07ddabd to
d6c3197
Compare
|
/test-all |
tnqn
approved these changes
Aug 28, 2023
|
@antoninbas |
The FlexibleIPAM e2e issue is tracked in #5451 , but we still need more discussion to fix this data plane bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #5409 on release-1.13.
#5409: Enable IPv6 on OVS internal port if needed in bridging mode
For details on the cherry pick process, see the cherry pick requests page.