Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Antrea IPAM for Antrea native secondary network support #5427

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Use Antrea IPAM for Antrea native secondary network support #5427

merged 1 commit into from
Nov 20, 2023

Conversation

jianjuns
Copy link
Contributor

@jianjuns jianjuns commented Aug 22, 2023 •
edited
Loading

This commit changes Antrea managed secondary networks to use Antrea IPAM for interface IP address allocation, and no longer use Whereabouts.

Issue: #5278

@jianjuns jianjuns added area/ipam Issues or PRs related to IP address management (IPAM). area/interface Issues or PRs related to network interfaces labels Aug 22, 2023
antoninbas
antoninbas reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not many comment from me. Maybe someone more familiar with the IPAM code should also review. Maybe @gran-vmv ?

pkg/agent/cniserver/ipam/antrea_ipam.go Outdated Show resolved Hide resolved
pkg/agent/cniserver/ipam/antrea_ipam.go Outdated Show resolved Hide resolved
pkg/agent/cniserver/ipam/antrea_ipam.go Outdated Show resolved Hide resolved
@jianjuns jianjuns requested a review from gran-vmv August 22, 2023 20:58
@jianjuns
Copy link
Contributor Author

Not many comment from me. Maybe someone more familiar with the IPAM code should also review. Maybe @gran-vmv ?

Added @gran-vmv as a reviewer.

@jianjuns jianjuns force-pushed the sec-antrea-ipam branch 2 times, most recently from 72fb4f1 to d7ebbc8 Compare August 23, 2023 00:15
@gran-vmv
Copy link
Contributor

LGTM for IPAM part.
Just a small comment: Do we have doc (for user) AND code comments (for dev) to explain these 2 different "secondary network" feature?

@jianjuns
Copy link
Contributor Author

LGTM for IPAM part. Just a small comment: Do we have doc (for user) AND code comments (for dev) to explain these 2 different "secondary network" feature?

For Multus, it is documented here: https://github.com/antrea-io/antrea/blob/main/docs/antrea-ipam.md#ipam-for-secondary-network.
For Antrea native secondary network, it is still WIP, and no documentation yet. But you can check the design here: #5278

tnqn
tnqn reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits

pkg/agent/secondarynetwork/podwatch/controller.go Outdated Show resolved Hide resolved
pkg/agent/secondarynetwork/podwatch/controller.go Outdated Show resolved Hide resolved
tnqn
tnqn previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john5985 john5985 mentioned this pull request Nov 10, 2023
Closed
@jianjuns
Use Antrea IPAM for Antrea native secondary network support
b6f78ee 
This commit changes Antrea managed secondary networks to use Antrea
IPAM for interface IP address allocation, and no longer use
Whereabouts.

Signed-off-by: Jianjun Shen <shenj@vmware.com>
@jianjuns
Copy link
Contributor Author

/test-all

@jianjuns jianjuns requested a review from tnqn November 20, 2023 03:17
tnqn
tnqn approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jianjuns jianjuns merged commit 5c8368b into antrea-io:main Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas left review comments

@tnqn tnqn tnqn approved these changes

@arunvelayutham arunvelayutham Awaiting requested review from arunvelayutham

@gran-vmv gran-vmv Awaiting requested review from gran-vmv

Assignees
No one assigned
Labels
area/interface Issues or PRs related to network interfaces area/ipam Issues or PRs related to IP address management (IPAM).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jianjuns @gran-vmv @antoninbas @tnqn