Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test testTraceflowValidation for IPv6-only cluster #5415

Merged

Conversation

antoninbas
Copy link
Contributor

The test case was making the assumption that every Pod always has an IPv4 address, which is not the case for IPv6-only clusters.

To simplify the test case, we use the Pod's namepspace/name to define the Traceflow destination, instead of the Pod's IP address.

The test case was making the assumption that every Pod always has an
IPv4 address, which is not the case for IPv6-only clusters.

To simplify the test case, we use the Pod's namepspace/name to define
the Traceflow destination, instead of the Pod's IP address.

Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas
Copy link
Contributor Author

/test-e2e
/test-ipv6-only-e2e
/test-ipv6-e2e

@antoninbas antoninbas requested review from tnqn and luolanzone August 21, 2023 22:20
@antoninbas
Copy link
Contributor Author

I cannot assign @shi0rik0, so tagging here

@antoninbas antoninbas added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Aug 21, 2023
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing it

@antoninbas
Copy link
Contributor Author

Relevant tests are passing. I am merging this to fix CI.

@antoninbas antoninbas merged commit b439013 into antrea-io:main Aug 22, 2023
@antoninbas antoninbas deleted the fix-e2e-tf-tests-for-ipv6-only branch August 22, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants