Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install flows for nested Services in EndpointDNAT only when MC is enabled #5411

Merged

Conversation

hongliangl
Copy link
Contributor

At present, flows for nested Services that are used by the multi-cluster are unconditionally added to EndpointDNAT, leading to the presence of numerous redundant flows when the multi-cluster feature is inactive. With the proposed changes, these associated flows will be only installed when multi-cluster is enabled.

@hongliangl hongliangl requested review from tnqn and luolanzone August 21, 2023 07:25
@hongliangl hongliangl added the area/ovs/openflow Issues or PRs related to Open vSwitch Open Flow. label Aug 21, 2023
…bled

At present, flows for nested Services that are used by the multi-cluster
are unconditionally added to EndpointDNAT, leading to the presence of numerous
redundant flows when the multi-cluster feature is inactive. With the proposed
changes, these associated flows will be only installed when multi-cluster is
enabled.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl hongliangl force-pushed the 20230821-dont_add_flows_when_mc_is_not_enabled branch from 8f14ea5 to 13a76a8 Compare August 23, 2023 01:23
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tnqn
Copy link
Member

tnqn commented Sep 20, 2023

/skip-all
/test-multicluster-e2e

@tnqn tnqn merged commit 5d92876 into antrea-io:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ovs/openflow Issues or PRs related to Open vSwitch Open Flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants