Automatically install new golangci-lint binary when version is bumped #4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, one had to manually remove the old binary for the new one to be installed. Signed-off-by: Antonin Bas <abas@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #4567 +/- ##
==========================================
+ Coverage 68.41% 68.50% +0.08%
==========================================
Files 400 400
Lines 58216 58216
==========================================
+ Hits 39829 39879 +50
+ Misses 15617 15568 -49
+ Partials 2770 2769 -1
*This pull request uses carry forward flags. Click here to find out more.
|
luolanzone
reviewed
Jan 18, 2023
| @@ -282,37 +286,38 @@ fmt: | |||
| @echo "===> Formatting Go files <===" | |||
| @gofmt -s -l -w $(GO_FILES) | |||
|
|
|||
| .golangci-bin: | |||
| $(GOLANGCI_LINT_BIN): | |||
There was a problem hiding this comment.
I suppose we also need to update the Makefile in hack/netpol?
There was a problem hiding this comment.
I didn't update it because it's dead code that we should remove (#1740)
|
/skip-all |
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Jan 27, 2023
…antrea-io#4567) Until now, one had to manually remove the old binary for the new one to be installed. Signed-off-by: Antonin Bas <abas@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, one had to manually remove the old binary for the new one to be installed.
Signed-off-by: Antonin Bas abas@vmware.com