Fix nil error issue #4154
Merged
Fix nil error issue #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-multicluster-e2e |
jianjuns
previously approved these changes
Aug 26, 2022
|
sure, I will backport it after it's merged. thanks. |
Codecov Report
@@ Coverage Diff @@
## main #4154 +/- ##
==========================================
- Coverage 65.08% 63.27% -1.82%
==========================================
Files 303 304 +1
Lines 46561 46626 +65
==========================================
- Hits 30304 29501 -803
- Misses 13903 14774 +871
+ Partials 2354 2351 -3
|
tnqn
reviewed
Aug 26, 2022
5bc099a to
0e4948b
Compare
|
/test-multicluster-e2e |
admission.Errored doesn't handle nil error case, it will raise a nil pointer error when there is no ClusterSet found. Fix it with a new error with error message. Refactor unit test and add a few more test cases. Signed-off-by: Lan Luo <luola@vmware.com>
0e4948b to
bb89c75
Compare
jianjuns
approved these changes
Aug 26, 2022
tnqn
approved these changes
Aug 29, 2022
|
/skip-networkpolicy |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
admission.Errored doesn't handle nil error case, it will raise a nil pointer error when there is no ClusterSet found. Fix it with a new error with error message. Refactor unit test and add a few more test cases. Signed-off-by: Lan Luo <luola@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admission.Errored doesn't handle nil error case, it will raise a nil
pointer error when there is no ClusterSet found.
Fix it with a new error with error message.
Refactor unit test and add a few more test cases.
Signed-off-by: Lan Luo luola@vmware.com