Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging for GroupMembersComputed update #4114

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Aug 15, 2022

Signed-off-by: Quan Tian qtian@vmware.com

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn requested a review from qiyueyao August 15, 2022 08:45
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #4114 (c5a926f) into main (cab72fc) will decrease coverage by 1.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4114      +/-   ##
==========================================
- Coverage   63.65%   62.57%   -1.08%     
==========================================
  Files         300      304       +4     
  Lines       46567    46775     +208     
==========================================
- Hits        29640    29268     -372     
- Misses      14596    15121     +525     
- Partials     2331     2386      +55     
Flag Coverage Δ
integration-tests 34.97% <ø> (+<0.01%) ⬆️
kind-e2e-tests 42.29% <0.00%> (-4.18%) ⬇️
unit-tests 43.94% <0.00%> (-0.02%) ⬇️
Impacted Files Coverage Δ
pkg/controller/networkpolicy/group.go 34.86% <0.00%> (ø)
pkg/agent/proxy/endpointslicecache.go 0.00% <0.00%> (-83.60%) ⬇️
pkg/agent/secondarynetwork/cnipodcache/cache.go 0.00% <0.00%> (-77.56%) ⬇️
pkg/controller/egress/store/egressgroup.go 1.72% <0.00%> (-54.32%) ⬇️
...g/agent/controller/serviceexternalip/controller.go 35.83% <0.00%> (-45.74%) ⬇️
pkg/agent/secondarynetwork/podwatch/controller.go 0.00% <0.00%> (-39.02%) ⬇️
...agent/flowexporter/connections/deny_connections.go 43.01% <0.00%> (-22.59%) ⬇️
pkg/agent/util/net.go 25.46% <0.00%> (-20.23%) ⬇️
pkg/agent/ipassigner/responder/arp_responder.go 55.29% <0.00%> (-17.65%) ⬇️
pkg/controller/externalnode/controller.go 0.00% <0.00%> (-17.19%) ⬇️
... and 80 more

Copy link
Contributor

@qiyueyao qiyueyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, LGTM

@tnqn
Copy link
Member Author

tnqn commented Aug 17, 2022

/skip-all

@tnqn tnqn merged commit 8feb48d into antrea-io:main Aug 17, 2022
@tnqn tnqn deleted the fix-log branch August 17, 2022 09:42
heanlan pushed a commit to heanlan/antrea that referenced this pull request Mar 29, 2023
Signed-off-by: Quan Tian <qtian@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants