Bugfix: socket is leak on IPv6 testbed #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-ipv6-only-e2e |
Codecov Report
@@ Coverage Diff @@
## main #4104 +/- ##
==========================================
+ Coverage 64.42% 67.56% +3.13%
==========================================
Files 299 299
Lines 45448 45450 +2
==========================================
+ Hits 29281 30708 +1427
+ Misses 13799 12355 -1444
- Partials 2368 2387 +19
|
Agent sends IPv6 Gratuitous NDP packet on each Pod to broadcast its address. The socket is not closed after sending packet, which introduces socket leak. To resolve the issue, adding a defer function to close the socket after writing the packet into the connection. Signed-off-by: wenyingd <wenyingd@vmware.com>
b9a34eb to
916eab3
Compare
|
/test-all |
|
/test-ipv6-networkpolicy |
|
/test-flexible-ipam-e2e |
gran-vmv
approved these changes
Aug 15, 2022
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
Agent sends IPv6 Gratuitous NDP packet on each Pod to broadcast its address. The socket is not closed after sending packet, which introduces socket leak. To resolve the issue, adding a defer function to close the socket after writing the packet into the connection. Signed-off-by: wenyingd <wenyingd@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agent sends IPv6 Gratuitous NDP packet on each Pod to broadcast its
address. The socket is not closed after sending packet, which introduces
socket leak.
To resolve the issue, adding a defer function to close the socket after
writing the packet into the connection.
Fixes #4086
Signed-off-by: wenyingd wenyingd@vmware.com