Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow Up] Audit Logging support K8s Networkpolicy #4099

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

qiyueyao
Copy link
Contributor

Addresses followup comments in Audit Logging support K8s Networkpolicy #4047.

Signed-off-by: Qiyue Yao yaoq@vmware.com

@qiyueyao qiyueyao changed the title Audit Logging support K8s Networkpolicy [Follow Up] [Follow Up] Audit Logging support K8s Networkpolicy Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #4099 (dc6c38c) into main (04b9dc6) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4099      +/-   ##
==========================================
- Coverage   67.17%   67.09%   -0.08%     
==========================================
  Files         298      298              
  Lines       45465    45465              
==========================================
- Hits        30539    30504      -35     
- Misses      12532    12556      +24     
- Partials     2394     2405      +11     
Flag Coverage Δ
integration-tests 35.32% <ø> (-0.07%) ⬇️
kind-e2e-tests 49.55% <ø> (-0.58%) ⬇️
unit-tests 44.28% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
.../agent/flowexporter/priorityqueue/priorityqueue.go 65.55% <0.00%> (-27.78%) ⬇️
...nt/apiserver/handlers/serviceexternalip/handler.go 37.03% <0.00%> (-14.82%) ⬇️
.../flowexporter/connections/conntrack_connections.go 66.66% <0.00%> (-13.81%) ⬇️
...agent/flowexporter/connections/deny_connections.go 74.19% <0.00%> (-10.76%) ⬇️
pkg/agent/flowexporter/utils.go 72.34% <0.00%> (-8.52%) ⬇️
pkg/agent/interfacestore/types.go 61.11% <0.00%> (-8.34%) ⬇️
pkg/controller/networkpolicy/tier.go 50.00% <0.00%> (-5.00%) ⬇️
pkg/agent/controller/trafficcontrol/controller.go 77.95% <0.00%> (-4.41%) ⬇️
pkg/agent/controller/networkpolicy/packetin.go 69.59% <0.00%> (-2.71%) ⬇️
...trollers/multicluster/resourceexport_controller.go 75.13% <0.00%> (-2.46%) ⬇️
... and 19 more

Addresses followup comments in Audit Logging supports K8s Networkpolicy.
- Improved documentation
- Improved e2e test

Signed-off-by: Qiyue Yao <yaoq@vmware.com>
@qiyueyao qiyueyao force-pushed the log-k8s-drop-follow-up branch from a7ea985 to dc6c38c Compare August 10, 2022 23:25
@salv-orlando salv-orlando added this to the Antrea v1.9 release milestone Aug 11, 2022
@tnqn
Copy link
Member

tnqn commented Aug 15, 2022

/skip-all

@tnqn tnqn merged commit cab72fc into antrea-io:main Aug 15, 2022
@qiyueyao qiyueyao deleted the log-k8s-drop-follow-up branch August 17, 2022 04:22
@qiyueyao qiyueyao added the action/backport Indicates a PR that requires backports. label Sep 3, 2022
heanlan pushed a commit to heanlan/antrea that referenced this pull request Mar 29, 2023
Addresses followup comments in Audit Logging supports K8s Networkpolicy.
- Improved documentation
- Improved e2e test

Signed-off-by: Qiyue Yao <yaoq@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/backport Indicates a PR that requires backports.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants