Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show IP counters when kubectl getting IPPools #4088

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Aug 8, 2022

To make the output informative and consistent with ExternalIPPools.

Signed-off-by: Quan Tian qtian@vmware.com

Before:

# kubectl get ippools
NAME    AGE
pool1   10h

After:

# kubectl get ippools
NAME    TOTAL   USED   AGE
pool1   9       3      10h

To make the output informative and consistent with ExternalIPPools.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn requested review from antoninbas and ksamoray August 8, 2022 15:47
@tnqn tnqn added this to the Antrea v1.8 release milestone Aug 8, 2022
@tnqn
Copy link
Member Author

tnqn commented Aug 8, 2022

/skip-all

1 similar comment
@tnqn
Copy link
Member Author

tnqn commented Aug 8, 2022

/skip-all

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #4088 (eacab02) into main (7ec0860) will increase coverage by 3.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4088      +/-   ##
==========================================
+ Coverage   64.24%   67.39%   +3.15%     
==========================================
  Files         294      297       +3     
  Lines       44809    44903      +94     
==========================================
+ Hits        28787    30263    +1476     
+ Misses      13671    12284    -1387     
- Partials     2351     2356       +5     
Flag Coverage Δ
integration-tests 35.19% <ø> (?)
kind-e2e-tests 50.32% <ø> (-0.22%) ⬇️
unit-tests 44.35% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
pkg/agent/cniserver/ipam/antrea_ipam.go 51.08% <0.00%> (-24.68%) ⬇️
pkg/apiserver/handlers/endpoint/handler.go 56.52% <0.00%> (-13.05%) ⬇️
pkg/agent/proxy/topology.go 72.72% <0.00%> (-9.10%) ⬇️
pkg/ipam/poolallocator/allocator.go 50.71% <0.00%> (-5.00%) ⬇️
pkg/controller/networkpolicy/tier.go 50.00% <0.00%> (-5.00%) ⬇️
pkg/agent/consistenthash/consistenthash.go 93.75% <0.00%> (-3.75%) ⬇️
pkg/agent/memberlist/cluster.go 71.24% <0.00%> (-2.88%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 79.45% <0.00%> (-1.37%) ⬇️
pkg/agent/controller/networkpolicy/reconciler.go 70.36% <0.00%> (-1.15%) ⬇️
pkg/agent/proxy/proxier.go 65.06% <0.00%> (-0.90%) ⬇️
... and 50 more

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn tnqn merged commit 83c86e2 into antrea-io:main Aug 9, 2022
@tnqn tnqn deleted the show-ip-pool-status branch August 9, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants