Release Antrea Helm chart archive for each Antrea release #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3935 +/- ##
===========================================
+ Coverage 49.03% 63.96% +14.92%
===========================================
Files 261 293 +32
Lines 39245 43300 +4055
===========================================
+ Hits 19245 27698 +8453
+ Misses 18128 13360 -4768
- Partials 1872 2242 +370
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tnqn
reviewed
Jun 24, 2022
tnqn
reviewed
Jun 24, 2022
| # We also generate a manifest which only includes CRD resources (all of them). | ||
| # This is useful for Antrea upgrades when using Helm. | ||
| CRD_FILES=$(cd $ANTREA_CHART/crds && find * -type f -name "*.yaml" ) | ||
| CRD_OUTPUT_FILE="$OUTPUT_DIR/antrea-crds.yml" |
There was a problem hiding this comment.
this file is not checked in and is not in .gitignore, is it intentional?
There was a problem hiding this comment.
I think it's checked in already?
Github is collapsing it, but I can see it in the diff
There was a problem hiding this comment.
Ah, I thought it was not checked in because I saw it in the diff.
For each Antrea release, we generate the correct Helm chart archive and upload it as a release asset. The appropriate index.yaml file (Helm repo index) will be updated appropriately (in the antrea-io/website repository) and will be accessible through charts.antrea.io and / or antrea.io/charts. For antrea-io#2641 We are also moving all CRD resources from the generic templates/ directory to the special crds/ directory, in the Chart definition. This will cause Helm to treat CRDs as special resources, and in particular they will never be upgraded / deleted automatically by Helm. In particular, for upgrade, users will need to apply a separate YAML (which is being added to release assets) including all the CRD resource definitions. This represents an extra step, but ensures that users are aware that CRDs are being upgraded which may require some actions from them (e.g., migrate to a new version) and needs to be done with caution. Fixes antrea-io#3665 Signed-off-by: Antonin Bas <abas@vmware.com>
52c48fd to
ca73949
Compare
tnqn
reviewed
Jun 24, 2022
| # We also generate a manifest which only includes CRD resources (all of them). | ||
| # This is useful for Antrea upgrades when using Helm. | ||
| CRD_FILES=$(cd $ANTREA_CHART/crds && find * -type f -name "*.yaml" ) | ||
| CRD_OUTPUT_FILE="$OUTPUT_DIR/antrea-crds.yml" |
There was a problem hiding this comment.
Ah, I thought it was not checked in because I saw it in the diff.
hack/generate-helm-release.sh
Outdated
| >&2 echo "$@" | ||
| } | ||
|
|
||
| _usage="Usage: $0 [--mode (dev|release)] --out <DIR> |
There was a problem hiding this comment.
should it use --out <PATH> as this could be a directory or a file?
hack/generate-helm-release.sh
Outdated
| _usage="Usage: $0 [--mode (dev|release)] --out <DIR> | ||
| Package the Antrea chart into a chart archive. | ||
| Environment variable VERSION must be set. | ||
| --out <DIR> Output path for chart archive |
Signed-off-by: Antonin Bas <abas@vmware.com>
ca73949 to
3c3d527
Compare
|
@tnqn I had to regenerate the chart README |
Signed-off-by: Antonin Bas <abas@vmware.com>
c53bbe6 to
10cda94
Compare
jianjuns
approved these changes
Jun 27, 2022
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each Antrea release, we generate the correct Helm chart archive and
upload it as a release asset. The appropriate index.yaml file (Helm repo
index) will be updated appropriately (in the antrea-io/website
repository) and will be accessible through charts.antrea.io and / or
antrea.io/charts.
For #2641
We are also moving all CRD resources from the generic templates/
directory to the special crds/ directory, in the Chart definition. This
will cause Helm to treat CRDs as special resources, and in particular
they will never be upgraded / deleted automatically by Helm. In
particular, for upgrade, users will need to apply a separate YAML (which
is being added to release assets) including all the CRD resource
definitions. This represents an extra step, but ensures that users are
aware that CRDs are being upgraded which may require some actions from
them (e.g., migrate to a new version) and needs to be done with caution.
Fixes #3665
Signed-off-by: Antonin Bas abas@vmware.com