Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Windows script #3904

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

wenyingd
Copy link
Contributor

Rename Windows script Start.ps1 as Start-AntreaAgent.ps1, and rename
Stop.ps1 as Stop-AntreaAgent.ps1.

Signed-off-by: wenyingd wenyingd@vmware.com

Rename Windows script Start.ps1 as Start-AntreaAgent.ps1, and rename
Stop.ps1 as Stop-AntreaAgent.ps1.

Signed-off-by: wenyingd <wenyingd@vmware.com>
@wenyingd wenyingd assigned jianjuns and unassigned jianjuns Jun 16, 2022
@wenyingd wenyingd requested a review from jianjuns June 16, 2022 02:53
@wenyingd
Copy link
Contributor Author

/skip-all
/test-windows-all

Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we name "PrepareNode.ps1" to "Prepare-Node.ps1" to be consistent with other files? I did not check all files to know any other inconsistence.

@wenyingd
Copy link
Contributor Author

Let me check them and modify in this change.

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #3904 (dabf823) into main (59fc30a) will increase coverage by 20.68%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3904       +/-   ##
===========================================
+ Coverage   35.16%   55.85%   +20.68%     
===========================================
  Files         122      415      +293     
  Lines       17123    60347    +43224     
===========================================
+ Hits         6022    33704    +27682     
- Misses      10602    23907    +13305     
- Partials      499     2736     +2237     
Flag Coverage Δ
integration-tests 35.16% <ø> (ø)
kind-e2e-tests 50.36% <ø> (?)
unit-tests 44.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/handlers/webhook/mutation_crd.go 52.17% <0.00%> (ø)
...ver/registry/controlplane/nodestatssummary/rest.go 100.00% <0.00%> (ø)
pkg/agent/openflow/cookie/allocator.go 76.74% <0.00%> (ø)
...ntrollers/multicluster/serviceexport_controller.go 66.47% <0.00%> (ø)
pkg/apiserver/handlers/webhook/convert_crd.go 3.92% <0.00%> (ø)
...uster/controllers/multicluster/stale_controller.go 51.72% <0.00%> (ø)
pkg/controller/networkpolicy/convert.go 0.00% <0.00%> (ø)
pkg/querier/querier.go 55.00% <0.00%> (ø)
pkg/agent/openflow/egress.go 69.44% <0.00%> (ø)
...rver/registry/networkpolicy/appliedtogroup/rest.go 66.66% <0.00%> (ø)
... and 283 more

@wenyingd
Copy link
Contributor Author

Should we name "PrepareNode.ps1" to "Prepare-Node.ps1" to be consistent with other files? I did not check all files to know any other inconsistence.

Checked code, only Start.ps1 ( Start-AntreaAgent.ps1) is uploaded in Antrea assets. All powershell provided by Antrea uses "-" to connect the verb and subject. The "PrepareNode.ps1" you mentioned in windows.md is not the script provided by Antrea, but downloaded from https://github.com/kubernetes-sigs/sig-windows-tools, so is StartKubelet.ps1 which is automatically generated by PrepareNode.ps1. Our own Prepare-Node.ps1 is not referrenced in the documentations or CI scripts, it can be downloaded by delevopers or users only from the code branches.

@wenyingd wenyingd requested a review from jianjuns June 16, 2022 08:01
@jianjuns jianjuns merged commit 5b9cde5 into antrea-io:main Jun 16, 2022
@wenyingd wenyingd deleted the rename_windows_scripts branch August 15, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants