-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Windows script #3904
Rename Windows script #3904
Conversation
Rename Windows script Start.ps1 as Start-AntreaAgent.ps1, and rename Stop.ps1 as Stop-AntreaAgent.ps1. Signed-off-by: wenyingd <wenyingd@vmware.com>
/skip-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we name "PrepareNode.ps1" to "Prepare-Node.ps1" to be consistent with other files? I did not check all files to know any other inconsistence.
Let me check them and modify in this change. |
Codecov Report
@@ Coverage Diff @@
## main #3904 +/- ##
===========================================
+ Coverage 35.16% 55.85% +20.68%
===========================================
Files 122 415 +293
Lines 17123 60347 +43224
===========================================
+ Hits 6022 33704 +27682
- Misses 10602 23907 +13305
- Partials 499 2736 +2237
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Checked code, only Start.ps1 ( Start-AntreaAgent.ps1) is uploaded in Antrea assets. All powershell provided by Antrea uses "-" to connect the verb and subject. The "PrepareNode.ps1" you mentioned in |
Rename Windows script Start.ps1 as Start-AntreaAgent.ps1, and rename
Stop.ps1 as Stop-AntreaAgent.ps1.
Signed-off-by: wenyingd wenyingd@vmware.com