Fix error loop caused by failure to delete a non-existing route #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3827 +/- ##
==========================================
+ Coverage 38.20% 46.14% +7.94%
==========================================
Files 114 247 +133
Lines 15688 35914 +20226
==========================================
+ Hits 5993 16572 +10579
- Misses 9215 17704 +8489
- Partials 480 1638 +1158
Flags with carried forward coverage won't be shown. Click here to find out more. |
jianjuns
reviewed
May 25, 2022
pkg/agent/route/route_linux.go
Outdated
| @@ -1298,9 +1298,10 @@ func (c *Client) deleteLoadBalancerIngressIPRoute(svcIPStr string) error { | |||
|
|
|||
| route := generateRoute(svcIP, mask, gw, linkIndex, netlink.SCOPE_UNIVERSE) | |||
| if err := netlink.RouteDel(route); err != nil { | |||
| return fmt.Errorf("failed to delete routing entry for LoadBalancer ingress IP %s: %w", svcIP.String(), err) | |||
| klog.Warningf("Failed to delete routing entry for LoadBalancer ingress IP %s: %w", svcIP.String(), err) | |||
There was a problem hiding this comment.
We should be able to check and ignore only the not-found/exist error?
There was a problem hiding this comment.
I think we can log not-found/exist error.
antoninbas
reviewed
May 25, 2022
07c9930 to
3b05037
Compare
3b05037 to
58051d7
Compare
When a LoadBalancer with ingress IP is created, corresponding route for the ingress IP is also installed. When deleting the LoadBalancer, corresponding route should be also uninstalled. Before uninstalling the route, if the route is removed, then deleting the route will get a failure and return an error. The error will trigger LoadBalancer deletion again, and obviously, deleting the route will get a failure and return an error another time, resulting in an error loop. This PR fixes error loop by printing log instead of returning error when getting the error "no such process" (such error means that the route expected to be deleted doesn't exist). Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
58051d7 to
d99e856
Compare
jianjuns
approved these changes
May 26, 2022
|
/test-all |
|
/test-ipv6-e2e |
|
/test-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a LoadBalancer with ingress IP is created, corresponding route
for the ingress IP is also installed. When deleting the LoadBalancer,
corresponding route should be also uninstalled. Before uninstalling
the route, if the route is removed, then deleting the route will
get a failure and return an error. The error will trigger LoadBalancer
deletion again, and obviously, deleting the route will get a failure
and return an error another time, resulting in an error loop. This PR
fixes error loop by printing log instead of returning error when getting
the error "no such process" (such error means that the route expected to
be deleted doesn't exist).
Signed-off-by: Hongliang Liu lhongliang@vmware.com