Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate egress.to.namespaces.match of AntreaClusterNetworkPolicy rules #3727

Merged
merged 1 commit into from
May 6, 2022

Conversation

qiyueyao
Copy link
Contributor

@qiyueyao qiyueyao commented May 4, 2022

This is an addition to Validate namespaces.match of AntreaClusterNetworkPolicy rules #3109, the PR validated ingress.from, this PR adds the same validation to egress.to.

Signed-off-by: Qiyue Yao yaoq@vmware.com

Signed-off-by: Qiyue Yao <yaoq@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #3727 (19033aa) into main (8f451f7) will decrease coverage by 7.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3727      +/-   ##
==========================================
- Coverage   64.44%   57.25%   -7.19%     
==========================================
  Files         278      392     +114     
  Lines       39513    56451   +16938     
==========================================
+ Hits        25463    32323    +6860     
- Misses      12068    21679    +9611     
- Partials     1982     2449     +467     
Flag Coverage Δ
e2e-tests 46.19% <ø> (?)
integration-tests 38.02% <ø> (?)
kind-e2e-tests 51.84% <ø> (-0.51%) ⬇️
unit-tests 43.83% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/egress/store/egressgroup.go 1.72% <0.00%> (-54.32%) ⬇️
pkg/agent/flowexporter/utils.go 51.06% <0.00%> (-25.54%) ⬇️
pkg/agent/multicast/mcast_controller.go 45.98% <0.00%> (-21.47%) ⬇️
pkg/agent/route/route_linux.go 30.17% <0.00%> (-19.63%) ⬇️
pkg/agent/util/net.go 32.88% <0.00%> (-18.67%) ⬇️
pkg/agent/openflow/pod_connectivity.go 52.45% <0.00%> (-15.86%) ⬇️
pkg/controller/ipam/antrea_ipam_controller.go 63.63% <0.00%> (-15.45%) ⬇️
pkg/apiserver/handlers/endpoint/handler.go 56.52% <0.00%> (-13.05%) ⬇️
pkg/agent/util/ipset/ipset.go 59.45% <0.00%> (-8.11%) ⬇️
pkg/agent/openflow/service.go 78.16% <0.00%> (-5.75%) ⬇️
... and 142 more

@qiyueyao qiyueyao requested review from Dyanngg and tnqn May 4, 2022 20:54
Copy link
Contributor

@Dyanngg Dyanngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented May 6, 2022

/skip-conformance
/skip-networkpolicy
/test-e2e

@tnqn tnqn added the action/release-note Indicates a PR that should be included in release notes. label May 6, 2022
@tnqn tnqn merged commit fe21260 into antrea-io:main May 6, 2022
@qiyueyao qiyueyao deleted the fix-ns-match-validate branch May 16, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants