-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gateway and ClusterInfoImport CRDs #3689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3689 +/- ##
==========================================
- Coverage 64.33% 57.15% -7.19%
==========================================
Files 281 392 +111
Lines 39771 55082 +15311
==========================================
+ Hits 25588 31482 +5894
- Misses 12196 21140 +8944
- Partials 1987 2460 +473
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jianjuns
reviewed
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits.
multicluster/apis/multicluster/v1alpha1/clusterinfoimport_types.go
Outdated
Show resolved
Hide resolved
multicluster/apis/multicluster/v1alpha1/multiclusterconfig_types.go
Outdated
Show resolved
Hide resolved
* Add Gateway and ClusterInfoImport CRDs and update corresponding manifests - A sample of Gateway is like below: ```yaml apiVersion: multicluster.crd.antrea.io/v1alpha1 kind: Gateway metadata: name: k8s-node-1 namespace: kube-system gatewayIP: 172.16.27.224 internalIP: 172.16.27.224 ``` - A sample of ClusterInfoImport is like below: ```yaml apiVersion: multicluster.crd.antrea.io/v1alpha1 kind: ClusterInfoImport metadata: name: test-cluster-west-kube-system-clusterinfo namespace: kube-system spec: clusterID: test-cluster-west gatewayNodeInfos: - gatewayIP: 10.10.10.10 name: k8s-node-1 serviceCIDR: 10.19.0.0/18 ``` * Two new fields 'ServiceCIDR' and 'GatewayIPPrecedence' are added in MultiClusterConfig. - By default, MC controller will detect ClusterIP range automatically. If admin set the ServiceCIDR config manually, MC controller will use the value in the config. - By default, MC controller will chose InternalIP of a Node as the GatewayIP, if admin set GatewayIPPrecedence config as 'public', it will use ExternalIP as the GatewayIP. Signed-off-by: Lan Luo <luola@vmware.com>
jianjuns
approved these changes
Apr 27, 2022
/test-multicluster-e2e |
tnqn
approved these changes
Apr 27, 2022
/skip-all |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceCIDR config manually, MC controller will use the value in the config.
GatewayIPPrecedence config as 'public', it will use ExternalIP as the GatewayIP.
Signed-off-by: Lan Luo luola@vmware.com