Truncate SessionAffinity timeout values instead of wrapping around #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3609 +/- ##
===========================================
- Coverage 64.24% 46.84% -17.40%
===========================================
Files 278 245 -33
Lines 27929 35482 +7553
===========================================
- Hits 17942 16623 -1319
- Misses 8067 17221 +9154
+ Partials 1920 1638 -282
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jianjuns
previously approved these changes
Apr 9, 2022
|
/test-all |
tnqn
previously approved these changes
Apr 12, 2022
pkg/agent/proxy/proxier.go
Outdated
| // let the timeout value wrap around. | ||
| affinityTimeout = maxSupportedAffinityTimeout | ||
| if !ok || (svcInfo.StickyMaxAgeSeconds() != pSvcInfo.StickyMaxAgeSeconds()) { | ||
| // We only log a warning when the Service hasn't been instealled |
There was a problem hiding this comment.
Suggested change
| // We only log a warning when the Service hasn't been instealled | |
| // We only log a warning when the Service hasn't been installed |
SessionAffinity timeout is implemented using a hard_timeout in OVS. hard_timeout is represented by a uint16 in the OpenFlow protocol, hence we cannot support timeouts greater than 65535 seconds. However, the K8s Service spec allows timeout values up to 86400 seconds for ClientIP-based SessionAffinity (https://godoc.org/k8s.io/api/core/v1#ClientIPConfig). For values greater than 65535 seconds, we need to set the hard_timeout to 65535 rather than let the timeout value wrap around. For antrea-io#1578 Signed-off-by: Antonin Bas <abas@vmware.com>
f6c2a3d
c3229ed to
f6c2a3d
Compare
|
/test-all |
tnqn
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SessionAffinity timeout is implemented using a hard_timeout in
OVS. hard_timeout is represented by a uint16 in the OpenFlow protocol,
hence we cannot support timeouts greater than 65535 seconds. However,
the K8s Service spec allows timeout values up to 86400 seconds for
ClientIP-based SessionAffinity
(https://godoc.org/k8s.io/api/core/v1#ClientIPConfig). For values
greater than 65535 seconds, we need to set the hard_timeout to 65535
rather than let the timeout value wrap around.
For #1578
Signed-off-by: Antonin Bas abas@vmware.com