[Windows] Support traceflow #3022

gran-vmv · 2021-11-11T05:10:55Z

codecov-commenter · 2021-11-11T05:17:03Z

Codecov Report

Merging #3022 (2093295) into main (627239c) will decrease coverage by 18.49%.
The diff coverage is n/a.

❗ Current head 2093295 differs from pull request most recent head 19e66d8. Consider uploading reports for the commit 19e66d8 to get more accurate results

@@             Coverage Diff             @@
##             main    #3022       +/-   ##
===========================================
- Coverage   64.69%   46.19%   -18.50%     
===========================================
  Files         279      246       -33     
  Lines       39784    35914     -3870     
===========================================
- Hits        25738    16592     -9146     
- Misses      12051    17691     +5640     
+ Partials     1995     1631      -364

Flag	Coverage Δ
e2e-tests	`46.19% <ø> (?)`
kind-e2e-tests	`?`
unit-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/ipfix/ipfix_process.go	`0.00% <0.00%> (-100.00%)`	⬇️
pkg/ipfix/ipfix_registry.go	`0.00% <0.00%> (-100.00%)`	⬇️
.../agent/flowexporter/priorityqueue/priorityqueue.go	`0.00% <0.00%> (-92.41%)`	⬇️
pkg/ipfix/ipfix_intermediate.go	`0.00% <0.00%> (-90.91%)`	⬇️
...lowaggregator/clickhouseclient/clickhouseclient.go	`0.00% <0.00%> (-90.77%)`	⬇️
pkg/controller/networkpolicy/endpoint_querier.go	`4.58% <0.00%> (-88.08%)`	⬇️
pkg/agent/flowexporter/connections/conntrack.go	`0.00% <0.00%> (-85.72%)`	⬇️
.../agent/flowexporter/connections/conntrack_linux.go	`0.00% <0.00%> (-85.49%)`	⬇️
pkg/util/flowexport/flowexport.go	`0.00% <0.00%> (-84.62%)`	⬇️
...agent/flowexporter/connections/deny_connections.go	`0.00% <0.00%> (-83.91%)`	⬇️
... and 164 more

lzhecheng

LGTM

lzhecheng · 2021-11-16T03:44:23Z

/test-integration

test/e2e/traceflow_test.go

tnqn

LGTM

lzhecheng · 2021-11-17T07:33:20Z

/test-windows-e2e

gran-vmv · 2022-04-27T01:50:26Z

@wenyingd According to latest test result, the "tunnel-first-packet-issue" still exists in our private testbed.

wenyingd

LGTM, only two minor comments.

pkg/agent/openflow/client.go

wenyingd · 2022-04-28T02:53:39Z

test/e2e/traceflow_test.go

 		require.NoError(t, err)
 		svcIPv6Name = svcIPv6.Name
 	}

+	// Mesh ping to activate tunnel on Windows Node


Please add todo here to explain this is a workaround, and will be removed after Windows OVS fixes the issue that first packet is possibly dropped on tunnel because the ARP entry doesn't exist in host cache. The OVS issue link is: openvswitch/ovs-issues#253

Thanks. Added TODO here.

gran-vmv · 2022-04-29T02:39:42Z

/test-windows-e2e

wenyingd

LGTM

gran-vmv · 2022-05-05T06:07:19Z

/test-all
/test-windows-all

gran-vmv · 2022-05-05T06:08:01Z

/test-ipv6-all
/test-ipv6-only-all
/test-flexible-ipam-e2e

gran-vmv · 2022-05-05T06:08:26Z

/test-all-features-conformance
/test-multicluster-e2e

tnqn · 2022-05-05T08:47:55Z

test/e2e/traceflow_test.go

+	}
+	if encapMode != config.TrafficEncapModeNoEncap {
+		// https://github.com/antrea-io/antrea/issues/897
+		skipIfProviderIs(t, "kind", "Skipping inter-Node Traceflow test for Kind because of #897")


OVS datapath has switched to kernel, all issues related to #897 should be resolved now.

Thanks, removed.

test/e2e/traceflow_test.go

tnqn · 2022-05-05T08:55:24Z

test/e2e/traceflow_test.go

@@ -328,15 +340,16 @@ func testTraceflowIntraNode(t *testing.T, data *TestData) {
 		}
 	}()

-	antreaPod, err := data.getAntreaPodOnNode(node1)
-	if err = data.waitForNetworkpolicyRealized(antreaPod, allowAllEgressName, v1beta2.K8sNetworkPolicy); err != nil {


Why it no longer needs to wait for policy realization?

Discussed with wenying, and reverted this change.

gran-vmv · 2022-05-06T08:59:55Z

/test-windows-e2e

ci/jenkins/test.sh

test/e2e/traceflow_test.go

gran-vmv · 2022-05-09T01:42:22Z

/test-conformance
/test-e2e
/test-ipv6-e2e
/test-multicluster-e2e

Signed-off-by: gran <gran@vmware.com>

gran-vmv · 2022-05-10T01:42:44Z

/test-all
/test-windows-all
/test-ipv6-all
/test-ipv6-only-all
/test-flexible-ipam-e2e
/test-multicluster-e2e

gran-vmv · 2022-05-10T07:17:11Z

/test-all-features-conformance
/test-e2e
/test-ipv6-conformance
/test-ipv6-e2e
/test-multicluster-e2e
/test-networkpolicy
/test-windows-conformance
/test-windows-e2e
/test-windows-networkpolicy

tnqn

LGTM

gran-vmv self-assigned this Nov 11, 2021

gran-vmv changed the title ~~WIP: Enable traceflow e2e test on Windows~~ Enable traceflow e2e test on Windows Nov 12, 2021

gran-vmv requested review from lzhecheng and tnqn November 12, 2021 07:36

lzhecheng previously approved these changes Nov 16, 2021

View reviewed changes

tnqn reviewed Nov 16, 2021

View reviewed changes

test/e2e/traceflow_test.go Show resolved Hide resolved

gran-vmv dismissed lzhecheng’s stale review via 629db20 November 17, 2021 01:25

gran-vmv force-pushed the tf-win-e2e branch from ce4099d to 629db20 Compare November 17, 2021 01:25

tnqn previously approved these changes Nov 17, 2021

View reviewed changes

gran-vmv dismissed tnqn’s stale review via 4b83f2b November 17, 2021 02:51

gran-vmv force-pushed the tf-win-e2e branch 4 times, most recently from c2b8706 to e4a7ee7 Compare November 17, 2021 07:09

gran-vmv changed the title ~~Enable traceflow e2e test on Windows~~ WIP: Enable traceflow e2e test on Windows Nov 17, 2021

gran-vmv force-pushed the tf-win-e2e branch 3 times, most recently from d4a31a2 to 311cf4d Compare November 18, 2021 09:46

gran-vmv marked this pull request as draft November 19, 2021 02:54

gran-vmv force-pushed the tf-win-e2e branch 8 times, most recently from cc50a2f to cf8e369 Compare November 23, 2021 02:27

gran-vmv force-pushed the tf-win-e2e branch from e213bc3 to 4b990e4 Compare April 26, 2022 08:57

gran-vmv force-pushed the tf-win-e2e branch from 4b990e4 to 86e964d Compare April 28, 2022 01:50

wenyingd reviewed Apr 28, 2022

View reviewed changes

gran-vmv force-pushed the tf-win-e2e branch 2 times, most recently from b7828aa to 30fc40c Compare April 28, 2022 03:16

gran-vmv force-pushed the tf-win-e2e branch from 30fc40c to 2ef2ef6 Compare May 5, 2022 05:43

gran-vmv requested a review from wenyingd May 5, 2022 05:43

wenyingd previously approved these changes May 5, 2022

View reviewed changes

tnqn reviewed May 5, 2022

View reviewed changes

gran-vmv dismissed wenyingd’s stale review via 2f15b65 May 6, 2022 00:53

gran-vmv force-pushed the tf-win-e2e branch 3 times, most recently from c833b09 to a16ae20 Compare May 6, 2022 08:59

tnqn reviewed May 6, 2022

View reviewed changes

ci/jenkins/test.sh Outdated Show resolved Hide resolved

test/e2e/traceflow_test.go Outdated Show resolved Hide resolved

gran-vmv force-pushed the tf-win-e2e branch from a16ae20 to 86fca1e Compare May 7, 2022 02:15

gran-vmv force-pushed the tf-win-e2e branch from 86fca1e to 19e66d8 Compare May 9, 2022 02:09

Enable traceflow e2e test on Windows

bedfe53

Signed-off-by: gran <gran@vmware.com>

gran-vmv force-pushed the tf-win-e2e branch from 19e66d8 to bedfe53 Compare May 10, 2022 01:42

tnqn approved these changes May 10, 2022

View reviewed changes

tnqn added the action/release-note Indicates a PR that should be included in release notes. label May 10, 2022

tnqn merged commit 94311f9 into antrea-io:main May 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Windows] Support traceflow #3022

[Windows] Support traceflow #3022

gran-vmv commented Nov 11, 2021 •

edited

Loading

codecov-commenter commented Nov 11, 2021 •

edited

Loading

lzhecheng left a comment

lzhecheng commented Nov 16, 2021

tnqn left a comment

lzhecheng commented Nov 17, 2021

gran-vmv commented Apr 27, 2022

wenyingd left a comment

wenyingd Apr 28, 2022

gran-vmv Apr 28, 2022

gran-vmv commented Apr 29, 2022

wenyingd left a comment

gran-vmv commented May 5, 2022

gran-vmv commented May 5, 2022

gran-vmv commented May 5, 2022

tnqn May 5, 2022

gran-vmv May 6, 2022

tnqn May 5, 2022

gran-vmv May 6, 2022

gran-vmv commented May 6, 2022

gran-vmv commented May 9, 2022

gran-vmv commented May 10, 2022

gran-vmv commented May 10, 2022

tnqn left a comment

[Windows] Support traceflow #3022

[Windows] Support traceflow #3022

Conversation

gran-vmv commented Nov 11, 2021 • edited Loading

codecov-commenter commented Nov 11, 2021 • edited Loading

Codecov Report

lzhecheng left a comment

Choose a reason for hiding this comment

lzhecheng commented Nov 16, 2021

tnqn left a comment

Choose a reason for hiding this comment

lzhecheng commented Nov 17, 2021

gran-vmv commented Apr 27, 2022

wenyingd left a comment

Choose a reason for hiding this comment

wenyingd Apr 28, 2022

Choose a reason for hiding this comment

gran-vmv Apr 28, 2022

Choose a reason for hiding this comment

gran-vmv commented Apr 29, 2022

wenyingd left a comment

Choose a reason for hiding this comment

gran-vmv commented May 5, 2022

gran-vmv commented May 5, 2022

gran-vmv commented May 5, 2022

tnqn May 5, 2022

Choose a reason for hiding this comment

gran-vmv May 6, 2022

Choose a reason for hiding this comment

tnqn May 5, 2022

Choose a reason for hiding this comment

gran-vmv May 6, 2022

Choose a reason for hiding this comment

gran-vmv commented May 6, 2022

gran-vmv commented May 9, 2022

gran-vmv commented May 10, 2022

gran-vmv commented May 10, 2022

tnqn left a comment

Choose a reason for hiding this comment

gran-vmv commented Nov 11, 2021 •

edited

Loading

codecov-commenter commented Nov 11, 2021 •

edited

Loading