Automated cherry pick of #2429: Fix the deadlock between exporter and conntrack polling goroutines #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deadlock is due to the access of connection map from exporter goroutine waiting to acquire connection map lock to update the "DoneExport" flag of the stored connection. At the same time, the connection polling goroutine acquires the connection map lock waiting to acquire flow record map, which is acquired by the exporter goroutine. This was caught in scale testing. Resolved this through a temporary fix by adding the same flag in the flow record data struct. The connection and record deletion logic will be re-evaluated through PR antrea-io#2360 as it refactors the related code quite a bit. Signed-off-by: Srikar Tati <stati@vmware.com>
Codecov Report
@@ Coverage Diff @@
## release-1.2 #2446 +/- ##
===============================================
- Coverage 59.87% 59.83% -0.04%
===============================================
Files 284 284
Lines 22178 22170 -8
===============================================
- Hits 13278 13265 -13
- Misses 7474 7487 +13
+ Partials 1426 1418 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
antoninbas
approved these changes
Jul 22, 2021
|
/test-networkpolicy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #2429 on release-1.2.
#2429: Fix the deadlock between exporter and conntrack polling goroutines
For details on the cherry pick process, see the cherry pick requests page.