Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 address in traceflow using antctl CLI doesn't work #5541

Closed
Atish-iaf opened this issue Oct 4, 2023 · 0 comments · Fixed by #5588
Closed

IPv6 address in traceflow using antctl CLI doesn't work #5541

Atish-iaf opened this issue Oct 4, 2023 · 0 comments · Fixed by #5588
Assignees
Labels
area/component/antctl Issues or PRs releated to the command line interface component kind/bug Categorizes issue or PR as related to a bug.

Comments

@Atish-iaf
Copy link
Contributor

Atish-iaf commented Oct 4, 2023

Describe the bug

Using ipv6 address in source or destination of traceflow using antctl CLI doesn't work.

To Reproduce
Use ipv6 address in source or destination when doing traceflow using antctl CLI. For example :-
root@kind-worker2:/# antctl tf -f ipv6 -S default/pod2 -D fc00:f853:ccd:e793::2

Expected

Actual behavior

Error: error when creating Traceflow, is Traceflow feature gate enabled? Traceflow.crd.antrea.io "default-pod2-to-fc00:f853:ccd:e793::2-gnb8cv6s" is invalid: metadata.name: Invalid value: "default-pod2-to-fc00:f853:ccd:e793::2-gnb8cv6s": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*') 

Versions:

Additional context
Maybe we can replace : in traceflow name with - or . while processing the traceflow name.

@Atish-iaf Atish-iaf added kind/bug Categorizes issue or PR as related to a bug. area/component/antctl Issues or PRs releated to the command line interface component labels Oct 4, 2023
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Oct 17, 2023
Fixes antrea-io#5541

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
@Atish-iaf Atish-iaf self-assigned this Oct 17, 2023
@rajnkamr rajnkamr added this to the Antrea v1.14 release milestone Oct 17, 2023
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Oct 17, 2023
Fixes antrea-io#5541

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
antoninbas pushed a commit that referenced this issue Oct 17, 2023
The Traceflow CR name is generated based on Traceflow parameters,
which can include IPv6 addresses. We need to sanitize inputs to
generate a valid CR name.

Fixes #5541

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Oct 18, 2023
Fixes antrea-io#5541

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Atish-iaf added a commit to Atish-iaf/antrea that referenced this issue Oct 18, 2023
Fixes antrea-io#5541

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
tnqn pushed a commit that referenced this issue Oct 18, 2023
Fixes #5541

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
tnqn pushed a commit that referenced this issue Oct 18, 2023
Fixes #5541

Signed-off-by: Kumar Atish <atish.iaf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/component/antctl Issues or PRs releated to the command line interface component kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants