Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The auto-generated helm charts for release used wrong image tag #4137

Closed
tnqn opened this issue Aug 18, 2022 · 1 comment · Fixed by #4138
Closed

The auto-generated helm charts for release used wrong image tag #4137

tnqn opened this issue Aug 18, 2022 · 1 comment · Fixed by #4138
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@tnqn
Copy link
Member

tnqn commented Aug 18, 2022

Describe the bug

When I used helm to install Antrea 1.8.0, Antrea Pods can't be up and running because of missing image.
The image used by helm chart was "projects.registry.vmware.com/antrea/antrea-ubuntu:1.8.0" while it should be "projects.registry.vmware.com/antrea/antrea-ubuntu:v1.8.0".

It's because AppVersion is used as the tag, while it's set to 1.8.0.

image: "{{ .Values.image.repository }}:{{ default .Chart.AppVersion .Values.image.tag }}"

To work around the issue, I hardcoded .Values.image.tag to v1.8.0 when generating the chart and replaced the charts in release assets with the correct ones.

Theia's image "theia-clickhouse-monitor" has the same issue, I didn't handle it as there are some unexpected difference between the auto-generated chart and the one I generated manually so it's still failing.

@tnqn tnqn added the kind/bug Categorizes issue or PR as related to a bug. label Aug 18, 2022
@tnqn
Copy link
Member Author

tnqn commented Aug 18, 2022

@antoninbas @yanjunz97

@antoninbas antoninbas self-assigned this Aug 18, 2022
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 18, 2022
When installing a released version of a chart (for Antrea or the
FlowAggregator), the image tag was not generated correctly. It was
missing the leading "v".

Fixes antrea-io#4137

Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas added a commit that referenced this issue Aug 19, 2022
When installing a released version of a chart (for Antrea or the
FlowAggregator), the image tag was not generated correctly. It was
missing the leading "v".

Fixes #4137

Signed-off-by: Antonin Bas <abas@vmware.com>
yanjunz97 added a commit to antrea-io/theia that referenced this issue Aug 19, 2022
This PR is inspired by antrea-io/antrea#4138 and fixes the issue antrea-io/antrea#4137.

It adds the missing leading `v` for ClickHouse monitor image tag in the
released Helm chart.
It also fixes the wrong ClickHouse monitor image tag when generating
`flow-visibiltiy.yaml` for release.

Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 20, 2022
When installing a released version of a chart (for Antrea or the
FlowAggregator), the image tag was not generated correctly. It was
missing the leading "v".

Fixes antrea-io#4137

Signed-off-by: Antonin Bas <abas@vmware.com>
tnqn pushed a commit that referenced this issue Aug 24, 2022
When installing a released version of a chart (for Antrea or the
FlowAggregator), the image tag was not generated correctly. It was
missing the leading "v".

Fixes #4137

Signed-off-by: Antonin Bas <abas@vmware.com>
heanlan pushed a commit to heanlan/antrea that referenced this issue Mar 29, 2023
When installing a released version of a chart (for Antrea or the
FlowAggregator), the image tag was not generated correctly. It was
missing the leading "v".

Fixes antrea-io#4137

Signed-off-by: Antonin Bas <abas@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants